Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a web browser error tmg #393

Merged
merged 1 commit into from
May 26, 2022
Merged

fix a web browser error tmg #393

merged 1 commit into from
May 26, 2022

Conversation

Polkas
Copy link
Contributor

@Polkas Polkas commented May 26, 2022

closes https://github.com/insightsengineering/coredev-tasks/issues/241

fix a red web browser error

Not in NEWS as was not exposed to the end users.

@github-actions
Copy link
Contributor

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  ----------------------------------------------
R/tm_a_pca.R                    767     767  0.00%    69-965
R/tm_a_regression.R             695     695  0.00%    91-872
R/tm_data_table.R               168     168  0.00%    147-375
R/tm_file_viewer.R              169     169  0.00%    38-237
R/tm_front_page.R               122     111  9.02%    61-197
R/tm_g_association.R            263     263  0.00%    87-399
R/tm_g_bivariate.R              592     432  27.03%   105-612, 660, 666, 670, 781, 798, 816, 836-858
R/tm_g_distribution.R           939     939  0.00%    107-1193
R/tm_g_response.R               299     299  0.00%    83-439
R/tm_g_scatterplot.R            578     578  0.00%    140-792
R/tm_g_scatterplotmatrix.R      236     218  7.63%    79-325, 378, 392
R/tm_missing_data.R             994     994  0.00%    55-1200
R/tm_outliers.R                 946     946  0.00%    71-1146
R/tm_t_crosstable.R             222     222  0.00%    80-339
R/tm_variable_browser.R         737     732  0.68%    46-1173
R/utils.R                        89      89  0.00%    74-269
R/zzz.R                           1       1  0.00%    2
TOTAL                          7817    7623  2.48%

Results for commit: 14dc61106a1d0dabb200dae10402a17212c96008

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

Unit Tests Summary

  1 files    5 suites   0s ⏱️
16 tests 16 ✔️ 0 💤 0
49 runs  49 ✔️ 0 💤 0

Results for commit bb69fa5.

Copy link
Contributor

@denisovan31415 denisovan31415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Console error was reproducible and is now fixed on this PR

@Polkas Polkas merged commit 46bb1c6 into main May 26, 2022
@Polkas Polkas deleted the core_241@main branch May 26, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants