Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: remove {rlang} from {teal.transform} #191

Open
m7pr opened this issue Feb 13, 2024 · 0 comments
Open

[Feature Request]: remove {rlang} from {teal.transform} #191

m7pr opened this issue Feb 13, 2024 · 0 comments

Comments

@m7pr
Copy link
Contributor

m7pr commented Feb 13, 2024

{rlang} is used just a couple of times in 3 cases

  • rlang::is_empty -> substitute with length(x) == 0
  • rlang::set_names -> substitute with stats::setNames.
    • Documentation of rlang::set_namesstates: This is equivalent tostats::setNames()`, with more features and stricter argument checking.
  • rlang::parse_expr -> substitute with base::parse.
    • Documentation of rlang::parse_exprstates they are barely the same and the only difference is that: parser_expr, unlike base::parse, never retain source reference information, as doing so is slow and rarely necessary. We can substitute with parser(keep.source = FALSE).

Consider if we can substitute those with equivalents from {base} package.

Part of #194

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant