dynamic filter_spec: no variable selected should mean no filtering, and not filter out all data

[cicdguy]

NEST/teal.devel/issues/716

currently:

Despite SEX being selected in the select_spec there is no faceting because filter_spec is not selected. Currently, if filter_spec is not selected then it filters out all data.

At the very least, I think that if the variable of the filter_spec is not selected, then it should behave as if the filter_spec was simply not provided, i.e. no filtering.

We should ask, are there cases where the user would want to filter out ALL data?
If not, then even in the case where the variable is not empty but the value is empty, it should also mean no filtering, and not filter out all like it does currently:

Provenance:

Creator: junlue

[cicdguy]

If we want it to behave like e.g. Excel filtering, then no values should mean no rows selected.

Provenance:

Creator: kpagacz

[cicdguy]

Also, we should keep it consistent with the factor filtering we have. I think if we have factors that behave differently than numerics it will be a mess because there is no visual indication of a filter being a factor or numeric.

Provenance:

Creator: kpagacz

[cicdguy]

NEST/teal.devel/pull/721). In there, both factor and numeric behave the same way - no values selected, all rows filtered out.

Provenance:

Creator: kpagacz

[cicdguy]

@kpagacz

So then, no column selected should indicate no filtering?
I think this makes sense because then all possible behaviors will then be possible.

Currently, it is not possible to indicate no filtering whenever a filter_spec is provided.

Provenance:

Creator: junlue

[cicdguy]

@kpagacz

Conflict scenario: When filter_spec is not dynamic, how should it behave when all values (and therefore columns) are deselected?

Provenance:

Creator: junlue

[cicdguy]

I think there are much more cases in here because we can consider whether a select spec is provided as well.

Here is a link with a matrix of cases we can consider. https://drive.google.com/file/d/1lhgUqhTF3Jc_ethFALY74KZi3F90o5Ro/view?usp=sharing

Right now, I am not sure what would make sense. I will be filling the matrix in as I figure it out.

Feel free to jump in at the work @junlue I am not married to any ideas.

Provenance:

Creator: kpagacz

[cicdguy]

BTW: I think the case when values are empty should always behave as filtering out all rows.

Provenance:

Creator: kpagacz