Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign LBT05 layout to work with new rtables:: trim_levels_to_map and .spl_context #18

Closed
4 tasks done
cicdguy opened this issue Aug 5, 2021 · 2 comments · Fixed by #253
Closed
4 tasks done

Redesign LBT05 layout to work with new rtables:: trim_levels_to_map and .spl_context #18

cicdguy opened this issue Aug 5, 2021 · 2 comments · Fixed by #253
Milestone
Refactor safety t...

Comments

@cicdguy
Copy link
Contributor

cicdguy commented Aug 5, 2021 •
edited by imazubi
Loading

Redesign LBT05 family of functions (eg count_abnormal_by_marked, s_*, a_*) to work with rtables::trim_levels_to_map. Background issue (insightsengineering/rtables#203)

The idea is that based on metadata map the function can return either low , high, or low and high summary rows.

Rationale: improved speed, allow users to precisely control which combinations of levels among several categorical variables used in the layout should be displayed.

Please add the PR link(s) below.

  • tern design doc. Please use .spl_context approach. similar to LBT07
  • tern production code for s_, a_, layout function. Also please update relevant unit tests.
  • TLG-C update
  • nsdl.tests update
@cicdguy
Copy link
Contributor Author

cicdguy commented Aug 5, 2021

Moving to sprint 25

Provenance:

Creator: anajens

@cicdguy
Copy link
Contributor Author

cicdguy commented Aug 5, 2021

Note: moving to backlog until new split function is available in rtables.

Provenance:

Creator: anajens

@anajens anajens removed the blocked label Oct 21, 2021
@anajens anajens changed the title Redesign LBT05 layout to work with new split function Redesign LBT05 layout to work with new rtables:: trim_levels_to_map and .spl_context Nov 3, 2021
@imazubi imazubi self-assigned this Nov 8, 2021
@imazubi imazubi added sme and removed sme labels Nov 8, 2021
@anajens anajens added SP1 and removed SP1 labels Nov 8, 2021
@imazubi imazubi mentioned this issue Nov 10, 2021
Merged
@imazubi imazubi removed their assignment Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Refactor safety tables to use map spl...
Development

Successfully merging a pull request may close this issue.

issue 18: redesign count_abnormal_by_marked for lbt05 using .spl_context insightsengineering/tern
3 participants
@cicdguy @anajens @imazubi