Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor LBT04, EGT02, VST02, LBT15 layouts to work with trim_levels_to_map #96

Closed
5 tasks done
anajens opened this issue Aug 23, 2021 · 5 comments · Fixed by #127
Closed
5 tasks done

Refactor LBT04, EGT02, VST02, LBT15 layouts to work with trim_levels_to_map #96

anajens opened this issue Aug 23, 2021 · 5 comments · Fixed by #127
Assignees
Labels

Comments

@anajens
Copy link
Contributor

anajens commented Aug 23, 2021

Redesign family of functions used to create LBT04, EGT02, VST02, LBT15 layout to work with rtables::trim_levels_to_map. Background issue (insightsengineering/rtables#203)

Rationale: improved speed, allow users to precisely control which combinations of levels among several categorical variables used in the layout should be displayed.

Note note all of the step above may be relevant for the layout. If an update is necessary, please add the PR link below.

@anajens anajens self-assigned this Aug 23, 2021
@anajens anajens changed the title Redesign LBT04 layout to work with trim_levels_to_map Refactor LBT04 layout to work with trim_levels_to_map Aug 27, 2021
@anajens anajens changed the title Refactor LBT04 layout to work with trim_levels_to_map Refactor LBT04, EGT02, VST02, LBT15 layouts to work with trim_levels_to_map Aug 27, 2021
@anajens anajens linked a pull request Sep 7, 2021 that will close this issue
@anajens anajens reopened this Sep 9, 2021
@anajens
Copy link
Contributor Author

anajens commented Sep 23, 2021

Not ready for release, moving to backlog.

@yli110-stat697
Copy link
Contributor

Hi @anajens , for the nsdl.test, I tested with stream data for LBT04, EGT02, VST02. However for the LBT15, do you know how to define the theoretical map?

@yli110-stat697
Copy link
Contributor

TLGC MR is ready, but LBT15 map is not defined yet

@anajens anajens added the SP1 label Oct 27, 2021
@anajens
Copy link
Contributor Author

anajens commented Oct 27, 2021

@yli110-stat697 can we close this issue given that the TLG-C MR is closed in gitlab? For the missing LBT15 map I think it should be solved by the work in #230

@yli110-stat697
Copy link
Contributor

@yli110-stat697 can we close this issue given that the TLG-C MR is closed in gitlab? For the missing LBT15 map I think it should be solved by the work in #230

yes, closing now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants