Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-component generator not working #21

Closed
VinSpee opened this issue Dec 13, 2015 · 6 comments
Closed

react-component generator not working #21

VinSpee opened this issue Dec 13, 2015 · 6 comments
Labels

Comments

@VinSpee
Copy link

VinSpee commented Dec 13, 2015

Hi,

Great work here so far - extremely useful for bringing a set of ember-cli-like conventions which is sorely needed in the React community IMO.

I am attempting to use nwb to create a higher-order react component. The problem is that when I generate a component using:

nwb new react-component my-component

I am asked about UMD and give it a global.

It creates the directory and installs dependencies.

the resulting directory looks like this:

.
├── README.md
├── node_modules
├── npm-debug.log
└── package.json

1 directory, 3 files

However, when i create an app with nwb, the structure is correct:

.
├── README.md
├── node_modules
├── nwb.config.js
├── package.json
├── public
├── src
└── tests

4 directories, 3 files

and with web-modules:

.
├── README.md
└── package.json

0 directories, 2 files

any idea what could be causing this?

Thanks!

@insin insin added the bug label Dec 13, 2015
@insin
Copy link
Owner

insin commented Dec 13, 2015

Looks like npm pack only includes sub-dirs for the react-app template.

Investigating now.

@insin
Copy link
Owner

insin commented Dec 13, 2015

It looks like npm is reading the files config from each template's package.json and applying it when packaging nwb itself. Fix coming shortly.

@VinSpee
Copy link
Author

VinSpee commented Dec 13, 2015

thanks so much! Amazing response time hahaha :-)

@insin insin closed this as completed in a593e3b Dec 13, 2015
@insin
Copy link
Owner

insin commented Dec 13, 2015

This is fixed in the npm package for 0.4.1.

The source of the problem isn't fixed, will do that later.

@VinSpee
Copy link
Author

VinSpee commented Dec 13, 2015

👍🏼🏼👍🏼 all is well. thanks!

@insin
Copy link
Owner

insin commented Dec 13, 2015

NP, thanks for the bug report 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants