Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Volume control has no effect #13

Closed
BishopT opened this issue Apr 13, 2020 · 3 comments · Fixed by #14
Closed

Volume control has no effect #13

BishopT opened this issue Apr 13, 2020 · 3 comments · Fixed by #14
Labels
bug Something isn't working

Comments

@BishopT
Copy link
Contributor

BishopT commented Apr 13, 2020

App version 1.1.1 installed from Google Play.

The volume slider has no effect on VLC volume. The issue seems to come from a wrong command sent to VLC. Requested URI is: /requests/status.xml?command=volume&val=<float> when VLC wiki states:

 Allowed values are of the form:
   +<int>, -<int>, <int> or <int>%

See the screenshot of wireshark capture:
vlc-remote-volume-control-float
BishopT added a commit to BishopT/vlc_remote that referenced this issue Apr 13, 2020
@BishopT
Update remote_control.dart
f8bd14f 
compute scaledVolume as integer to fix insin#13 
(not tested)
@BishopT BishopT mentioned this issue Apr 13, 2020
Merged
@insin insin added the bug Something isn't working label Apr 13, 2020
@insin
Copy link
Owner

insin commented May 2, 2020

This is working for me (on emulator and Android device) as is, but let's merge the PR and round it to an int anyway

NCLAWSQ6av

@insin insin closed this as completed in #14 May 2, 2020
insin pushed a commit that referenced this issue May 2, 2020
@BishopT
Update remote_control.dart (#14)
37e93a2 
compute scaledVolume as integer to fix #13 
(not tested)
@BishopT
Copy link
Contributor Author

BishopT commented May 2, 2020

OK, thanks for feedback. Then I hope it's not hiding another problem. Will you be able to push an updated package on play store soon?

@BishopT
Copy link
Contributor Author

BishopT commented May 3, 2020

ok, got the update, works like a charm now 👍

@schwartzenheimer schwartzenheimer mentioned this issue May 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update remote_control.dart BishopT/vlc_remote
2 participants
@insin @BishopT