-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IRC Nicknames aren't showing up properly #11
Comments
hey Stefan, thanks for reporting! This should only happen when new people join the team, or if something goes wrong when fetching the user list upon the first connection, but it should be an easy fix. The first is basically #3 . The latter, I've never seen in practice. Can you verify if this issue appears only with newly joined people? Thanks |
I can't reproduce locally, but I had a feeling about what it could be. @chex3 mind to test it with this patch? https://github.com/insomniacslk/irc-slack/compare/nick_join_part |
I could reproduce the error. This happens on larger Slack channels/teams. Slack started truncating the list of members as of December 2017, https://api.slack.com/changelog/2017-10-members-array-truncating . Currently the list is capped at 500 members, so only 500 people per channel will be resolved from ID to name. The solution is to use |
I fixed the issue on my side but this also needs fixing in the underlying slack library as pointed out in the above PR |
I also need to port that code for groups, and refactor and clean it up |
done in 57df949 |
hi @insomniacslk , i noticed this issue still popping up, but in a somewhat different behaviour: I have a Slack environment where i'm part of 40 channels. And for the last 10 channels or so, it starts showing all the usernames as these However, when they type a message, i do see their proper handle. Example of such a channel:
(Initial is join, second is a |
The nickname, or username of the person chatting on each slack channel is not working properly.
In most cases, it is just sending a "U#######" string for each person, altho it does occasionally send a person's username:
I assume this is a Slack internal ID being sent out.
This is the number one bug/issue for me, makes chatting in the Slack channels almost useless, if I cant hilite people back in response in IRSSI.
Thanks!!
-- Stefan S
The text was updated successfully, but these errors were encountered: