Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private channels not being allowed to join #35

Closed
Syloq opened this issue Sep 26, 2018 · 5 comments
Closed

Private channels not being allowed to join #35

Syloq opened this issue Sep 26, 2018 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@Syloq
Copy link

Syloq commented Sep 26, 2018

After setting this up I noticed that when I tried to join a "private" channel on slack that it reported in the server log (and not to the client):

Cannot join channel #secret-channel-here: name_taken

I assume this is because secret/private channels on slack are treated in a completely different way. Is there a workaround for this?

@insomniacslk
Copy link
Owner

hey @Syloq , thanks for reporting this bug. This sounds like a regression, I will look into it

@insomniacslk
Copy link
Owner

insomniacslk commented Sep 27, 2018

@Syloq can you please test #36 and let me know if this fixes the issue for you?

Just run:

git clone https://github.com/insomniacslk/irc-slack.git -b fix_getconversations
cd irc-slack
go build
./irc-slack

@insomniacslk
Copy link
Owner

insomniacslk commented Sep 27, 2018

I merged the PR, it seems to be working well. Just try it from master (not from the fix_getconversations branch that I deleted). Please let me know if this doesn't work for you or if you find any issue (or feel free to close this issue)

@Syloq
Copy link
Author

Syloq commented Sep 27, 2018

@insomniacslk I was able to pull this just now and it works perfectly! Thanks for the fix.

@insomniacslk
Copy link
Owner

no problem, thank you and please keep testing and reporting bugs! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants