Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chef Automate support to inspec compliance login #1795

Closed
chris-rock opened this issue May 10, 2017 · 0 comments · Fixed by #2203
Closed

Add Chef Automate support to inspec compliance login #1795

chris-rock opened this issue May 10, 2017 · 0 comments · Fixed by #2203
Assignees
Labels
Type: Enhancement Improves an existing feature
Projects

Comments

@chris-rock
Copy link
Contributor

chris-rock commented May 10, 2017

The goal is to support Automate logins via inspec compliance login without requiring the existing login_automate.

Right now we have to different login methods for Chef Compliance and Chef Automate. We should harmonize those:

  • inspec compliance login_automate https://automate.compliance.test --insecure --user='admin' --ent='brewinc' --usertoken='%TOKEN%
  • 'inspec compliance login https://compliance.test --insecure --user='admin' --token='%TOKEN%'`

As you can see from the examples, only token and ent argument are different. We should use --token as the default and make --ent an optional argument. We may need a --type to indicate if this is a Chef Compliance or Automate server.

This issue should:

  • add Automate support to the login command (using the --token and --ent flag as required)
  • continue to support the --usertoken flag but output a deprecation warning
  • add a deprecation warning to the login_automate command

The removal of the login_automate command will come via a later change via #2154 in the next appropriate major release.

@chris-rock chris-rock added this to the InSpec 2.0 milestone May 10, 2017
@adamleff adamleff changed the title Replace login_automate with login for compliance plugin Add Chef Automate support to inspec compliance login Sep 14, 2017
@adamleff adamleff added Type: Enhancement Improves an existing feature and removed breaking-change labels Sep 14, 2017
@adamleff adamleff added this to Ready in InSpec Sep 14, 2017
@arlimus arlimus moved this from Ready to In Progress in InSpec Sep 27, 2017
@jerryaldrichiii jerryaldrichiii moved this from In Progress to Done in InSpec Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Improves an existing feature
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants