Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to ( progress | documentation ) format for test-kitchen inspec verifier #91

Closed
brentm5 opened this issue Jun 24, 2016 · 6 comments

Comments

@brentm5
Copy link

brentm5 commented Jun 24, 2016

It looks like the default inspec format for output has changed to not be as helpful when issues show up. For example lets say you have something like this:

describe file('/home/me/.ssh') do
  it { should exist }
  it { should be_file }
end

That would output a single line

✔  File /home/me/.ssh should exist

# And then a bunch of error with no context
... Blah

Not sure if this is something I am doing wrong on my system. Using inspec as a verifier is something we are trying to switch to but I would rather not add the following below:

verifier:
  name: inspec
  format: progress # <- This

Just trying to start a discussion on this, I can do the code. I believe it will be one line but not going to do that if its a waste of time and no one agrees.

@chris-rock
Copy link
Collaborator

chris-rock commented Jun 27, 2016

@brentm5 Thanks a lot for your feedback. This is very interesting, because most users complaint about the progress/documentation formatters, therefore simply changing the default formatter will not do the trick.
We are interested in improving the current InSpec formatter to address your use case. Please propose your ideas and name shortcomings of the InSpec formatter at inspec/inspec#532

@brentm5
Copy link
Author

brentm5 commented Aug 15, 2016

@chris-rock Thanks I will look at that issue.

@chris-rock
Copy link
Collaborator

@brentm5 We did a couple of improvement in InSpec 0.29.0 with the fix of inspec/inspec#812 If the issue still persists, please let me know

@brentm5
Copy link
Author

brentm5 commented Aug 15, 2016

That was really my complaint. Overall the format of the default output is fine from my standpoint. It was just tests failing overall but showing all green in the output when running inspec. Ill see if this fixes my issue and if it does then I will close this as this is just a duplicate of inspec/inspec#812 in my eyes.

@brentm5
Copy link
Author

brentm5 commented Aug 15, 2016

It is not the best view for the errors but it has been corrected so you can see the actual error with whats causing the issue so I consider this resolved.

@brentm5 brentm5 closed this as completed Aug 15, 2016
@chris-rock
Copy link
Collaborator

@brentm5 Could you add a ticket in InSpec to report what is missing and what you would expect?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants