Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

closes #4: Added Prometheus exporter and config validation #22

Merged
merged 4 commits into from Dec 18, 2018
Merged

closes #4: Added Prometheus exporter and config validation #22

merged 4 commits into from Dec 18, 2018

Conversation

JonasKunz
Copy link
Member

  • extended the Agent with a base class for services which can be dynamically activated, deactivated and configured through the inspectIT configuration mechanism
  • the prometheus OpenCensus exporter was added as a dynamic service (can be enabled, disabled and reconfigured at runtime)
  • added config validation via the hibernate implementation
  • moved the package rocks.inspectit.oce.config.service to rocks.inspectit.oce.service

ivansenic
ivansenic requested changes Dec 17, 2018
View reviewed changes
inspectit-oce-core/build.gradle Outdated Show resolved Hide resolved
inspectit-oce-core/build.gradle Outdated Show resolved Hide resolved
inspectit-oce-core/src/main/java/rocks/inspectit/oce/core/config/InspectitEnvironment.java Show resolved Hide resolved
...ctit-oce-core/src/main/java/rocks/inspectit/oce/core/exporter/PrometheusExporterService.java Outdated Show resolved Hide resolved
...ctit-oce-core/src/main/java/rocks/inspectit/oce/core/exporter/PrometheusExporterService.java Show resolved Hide resolved
...ctit-oce-core/src/main/java/rocks/inspectit/oce/core/exporter/PrometheusExporterService.java Outdated Show resolved Hide resolved
...ctit-oce-core/src/main/java/rocks/inspectit/oce/core/exporter/PrometheusExporterService.java Show resolved Hide resolved
...ctit-oce-core/src/main/java/rocks/inspectit/oce/core/exporter/PrometheusExporterService.java Show resolved Hide resolved
inspectit-oce-core/src/main/resources/config/default.yml Outdated Show resolved Hide resolved
ivansenic
ivansenic approved these changes Dec 18, 2018
View reviewed changes
Copy link
Member

@ivansenic ivansenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rocks 🕺

inspectit-oce-core/src/test/java/rocks/inspectit/oce/core/SpringTestBase.java Outdated Show resolved Hide resolved
inspectit-oce-core/src/test/java/rocks/inspectit/oce/core/SpringTestBase.java Show resolved Hide resolved
inspectit-oce-core/src/test/java/rocks/inspectit/oce/core/exporter/PrometheusExporterTest.java Outdated Show resolved Hide resolved
inspectit-oce-core/build.gradle Outdated Show resolved Hide resolved
inspectit-oce-core/src/test/java/rocks/inspectit/oce/core/exporter/PrometheusExporterTest.java Outdated Show resolved Hide resolved
@JonasKunz JonasKunz merged commit 079c415 into inspectIT:master Dec 18, 2018
@JonasKunz JonasKunz deleted the opencensus-loading branch December 18, 2018 12:01
@ivansenic ivansenic mentioned this pull request Dec 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivansenic ivansenic ivansenic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JonasKunz @ivansenic