Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFE] Improve CRD handling of Helm Charts #1814

Open
mqasimsarfraz opened this issue Jul 4, 2023 · 2 comments
Open

[RFE] Improve CRD handling of Helm Charts #1814

mqasimsarfraz opened this issue Jul 4, 2023 · 2 comments
Labels
lifecycle/staleproof Avoid this issue / PR being marked as stale by the bot.

Comments

@mqasimsarfraz
Copy link
Member

mqasimsarfraz commented Jul 4, 2023

As mentioned in the comment helm doesn't handle CRD upgrades well, so we either need to document or improve how helm handle the CRDs. As the comment here suggests we can simply move our CRD to templates directory to make this work but it needs to be tested and investigated.

According to helm/helm#8668 (comment):

If you're chart doesn't install custom resources just the CRDs... you can put the CRDs right into the templates directory.

@mqasimsarfraz
Copy link
Member Author

Seems like CRD with helm charts are indeed complicated [1] [2] but I also think our use-case is simple (w/o CRs, using ConfigMaps in future) so I will propose to move forward:

  • Move the charts to from crds to templates directory with an option skipCRDs (default: false) simplifying upgrades.
  • Document the workflow to use skipCRDs=false with kubectl apply ..., similar to cert-manager docs. in case user want to be careful with CRs.
  • Document the uninstall section with CRs removal to ensure we don't run into finalizers issue.

@mauriciovasquezbernal what do you think?

Copy link

github-actions bot commented Mar 7, 2024

This issue has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.

@github-actions github-actions bot added the lifecycle/stale Marked to be closed in next 14 days because of inactivity. label Mar 7, 2024
@mqasimsarfraz mqasimsarfraz added lifecycle/staleproof Avoid this issue / PR being marked as stale by the bot. and removed lifecycle/stale Marked to be closed in next 14 days because of inactivity. labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/staleproof Avoid this issue / PR being marked as stale by the bot.
Projects
Status: 🆕 New
Development

No branches or pull requests

1 participant