Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User mode to enable override #363

Closed
ghost opened this issue Nov 14, 2012 · 13 comments
Closed

User mode to enable override #363

ghost opened this issue Nov 14, 2012 · 13 comments
Labels
enhancement New feature or request
Milestone

Comments

@ghost
Copy link

ghost commented Nov 14, 2012

Currently, m_override just enables overrides for all opers with the privs to override what they're allowed to.

My proposal is that a new user mode (+O?) is added. If and only if an oper has that mode and override privileges in his/her O:line, overrides should be possible.

Rationale: Currently the override module is spammy (reports overrides for actions a user can be validly taking, like fetching a ban list) and it's very easy to produce an accidental override. Having an user mode would completely prevent accidents.

Additionally, it might be worth a thought to have a timer to remove the override-enabling usermode after a configurable amount of time (+ disabling the timer via configuration file).

@SadieCat
Copy link
Member

Additionally, it might be worth a thought to have a timer to remove the override-enabling usermode after a configurable amount of time (+ disabling the timer via configuration file).

This seems like a job which could be better implemented using m_timedmodes rather than having a seperate timer.

@HelixSpiral
Copy link
Contributor

I don't see why we still have this module, the m_sa* modules provide features to do anything necessary without 'accidental' overrides, and snotice spam for things you have access to without overriding.

@HelixSpiral
Copy link
Contributor

I don't think this should be given it's own mode.

@attilamolnar
Copy link
Member

@culex as i understand we're talking about two issues here:

  • m_override reports "overriding" when it shouldn't because the oper is allowed to do the action without having override privileges. The best solution to this would be to fix m_override to only send notices when an actual override happens.
  • It's easy to accidentally override. I think of this as a feature rather than a bug, as @shawn-smith has said, the ultimate solution to this is to use the /SA commands.

Nevertheless, i'll think about the user mode, it's a 2.2 thing anyway.

@ghost
Copy link
Author

ghost commented Nov 14, 2012

@shawn-smith I actually would like to point out that there is a difference, which might matter to more conservative individuals. /SAMODE allows changing another user's modes, m_override does not seem to provide any such thing.

@attilamolnar
Copy link
Member

@culex good point, changing another user's modes should be a seperate privilige

@HelixSpiral
Copy link
Contributor

Perhaps we should split user modes off into their own SAUMODE?

@attilamolnar
Copy link
Member

Either that, or a new oper privilige that allows opers exactly that, without the privilige they could only do /SAMODE #chan ...

@SadieCat
Copy link
Member

Personally I think it would be better as an oper priv than a seperate command. One of the good things about SA* currently is that the command names are consistent with the non-oper equivalents.

@HelixSpiral
Copy link
Contributor

Since 2.2 is currently getting development now, has anymore thought been given to this discussion?

I'm still against it. They are USERmodes, I don't want to see this end up looking like unreal with tons of oper-only usermodes.

@attilamolnar
Copy link
Member

Let's go for it as there's nothing to lose - no one will be forced to use the usermode on his server

@attilamolnar
Copy link
Member

@shawn-smith (opers are also users)

@attilamolnar
Copy link
Member

This functionality is now available, see m_override_umode in inspircd-extras. Issue remains open until this feature is made available in 2.2 too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

3 participants