Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

non-ascii journal titles #25

Closed
kaplun opened this issue Mar 30, 2017 · 5 comments
Closed

non-ascii journal titles #25

kaplun opened this issue Mar 30, 2017 · 5 comments
Assignees
@michamos
Labels
bug

Comments

@kaplun
Copy link
Contributor

kaplun commented Mar 30, 2017

https://sentry.cern.ch/inspire-sentry/inspire-labs/group/820653/
@kaplun kaplun added the bug label Mar 30, 2017
@michamos
Copy link
Contributor

this is not a refextract bug, the default format string was changed to unicode in #16, but inspire-next uses a different one that should be fixed as part of inspirehep/inspire-next#2133.

@michamos
Copy link
Contributor

@chris-asl the problem is here https://github.com/inspirehep/inspire-next/blob/master/inspirehep/modules/refextract/tasks.py#L90

@kaplun
Copy link
Contributor Author

kaplun commented Mar 30, 2017

Are you sure? The exception is triggered deep down in refextract code base.

@michamos
Copy link
Contributor

Yes, the format string gets passed to refextract and consumed deep inside (one of refextract great design decisions).

@kaplun
Copy link
Contributor Author

kaplun commented Mar 30, 2017

😱

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michamos michamos

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kaplun @michamos