-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instabug Pod Spec Modifies Project Files #7
Comments
First let me apologize for the late reply. Anyway, we've just pushed a new update for the SDK that should fix this issue. The new upload script will not fail your build incase any error happened. You can still remove the build script if you want to. Given the new build script, do you still think that the automation of adding the build script is annoying for you? |
I've also added a new branch that does the same as your PR, and I'll keep it updated with each SDK release. Now you'll have to use the command that points to this branch while integrating the SDK. Here's it: |
Thanks for the update. I'll talk it over with my coworkers, but I think your two proposed solutions still don't quite get to where we'd want to be. If you're dead set on imposing this build script phase on your users then I'd propose that you modify it to check for the presence of an env variable—say, INSTABUG_SKIP_UPLOAD_SCRIPT—and exit immediately if set. |
Why do you think that the other branch won't work for you? By using it the script won't even be added to your project! |
I want to be able to use Instabug via Cocoapods, but this munging of my project files with your dSYM upload script is unacceptable. I appreciate the thought, but I can take care of marshaling my own build artifacts. Our continuous-integration server is completely hosed as a result of this change, and one of my colleagues is in the process of setting up a fork as I type this, which would've been completely avoidable if this... feature... had been optional.
The text was updated successfully, but these errors were encountered: