Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails on RN 0.48 and iOS 11 #77

Closed
fforres opened this issue Sep 21, 2017 · 10 comments
Closed

Build fails on RN 0.48 and iOS 11 #77

fforres opened this issue Sep 21, 2017 · 10 comments
Assignees

Comments

@fforres
Copy link

fforres commented Sep 21, 2017

I'm getting some errors while trying to upgrade install 2.0.3 on RN 0.48.3 on an iOS device running iOS 11 on InstabugReactBridge.m:461

image

Out of the 6 errors, 5 are fixable by an xcode suggestion
Use of undeclared identifier 'IBGLogLevelTrace'; did you mean 'RCTLogLevelTrace'?
Use of undeclared identifier 'IBGLogLevelInfo'; did you mean 'RCTLogLevelInfo'?
Use of undeclared identifier 'IBGLogLevelWarning'; did you mean 'RCTLogLevelWarning'?
Use of undeclared identifier 'IBGLogLevelError'; did you mean 'RCTLogLevelError'?
Use of undeclared identifier 'IBGLogLevelFatal'; did you mean 'RCTLogLevelFatal'?

There is one error that is:
Implicit declaration of function 'IBGNSLogWithLevel' is invalid in C99

image

I came across this error by trying to upgrade to RN 0.48.3 with version 1.x and encountering the Redefinition of RCTMethodInfo error described here.
facebook/react-native#15775

Hopefully it helps

@fforres fforres changed the title Build failed on RN 0.48 and iOS 11 Build fails on RN 0.48 and iOS 11 Sep 21, 2017
@fforres
Copy link
Author

fforres commented Sep 21, 2017

PS: You folks are still supporting 1.x?
I created the pr with fix for 1.x version to support RN 0.48.3 but could not figure out if there was maybe a branch to keep supporting it?
Anyways, it's here but I closed it -> https://github.com/Instabug/instabug-reactnative/pull/78/files

@ghost ghost self-assigned this Sep 22, 2017
@ghost
Copy link

ghost commented Sep 23, 2017

Hey @fforres
I just need to make sure, are you following the [Upgrade Guide] when upgrading from version 1.x.x to version 2.0.3, you can find that here: 584befd

Regarding the PR for supporting version 1.x, I'll be checking this with the team and will get back to you about it 👍

Update: We are not going to support version 1.x as we don’t want to be depending on Cocoapods anymore

@SaraChicaD
Copy link

We had the same issue and had to comment out Instabug just to get our app to run. Would love an update on this! Thanks for your hard work on this package!

@ghost
Copy link

ghost commented Oct 7, 2017

Hey @SaraChicaD are you following the [Upgrade Guide] when upgrading from version 1.x.x to version 2.0.3, you can find that here: 584befd ?

@SaraChicaD
Copy link

SaraChicaD commented Oct 8, 2017

hi @reemalashry1 so i never updated, I installed 2 first. It just fails on iOS 11, but still works on Android? Thanks for your prompt reply!

screen shot 2017-10-08 at 11 39 32 am

@ghost
Copy link

ghost commented Oct 9, 2017

Hey @SaraChicaD this seems to be a different error, we will be checking this and I'll get back to you 😊

@ZiadAyman
Copy link

Hey @fforres are you still experiencing any problems now or shall I close this issue? :)

@fforres
Copy link
Author

fforres commented Nov 27, 2017

Sure @ZiadAyman :)
NP

@ZiadAyman
Copy link

Perfect!

Don't hesitate to get back whenever you need any help :)

@lock
Copy link

lock bot commented May 19, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants