Query from sql or file

[mathieuripert]

see #5

[mathieuripert]

it was possible to do things like

df1 = CustomersModel.query_from(sql='select id, name from zones where region_id={region_id}', region_id=1)

but now it fails with your changes
cc @neutralino1

[mathieuripert]

this fails for me

[mathieuripert]

why do you think we need os.environ['PWD'] instead of the dir path of the file that calls the method

[neutralino1]

Modules get imported from the directory python is running in, even if the code importing the module is deeper in the tree. The pattern I'm seeing in airflow is also to define paths (config files, resources...) with respect to the directory where python runs. I think it makes sense to follow that pattern.
This way modules can move around independently without the whole downstream tree having to follow.

[mathieuripert]

ok that works!

[mathieuripert]

hmm, but it could lead to issues, if we have some shared code from different services?

[mathieuripert]

i thought that would have been safer to define the path to sql file relative from where it is called, but i'll see when i use it in batching

[neutralino1]

@mathieuripert Yes, the correct syntax according to the rest of the API is

df1 = CustomersModel.query_from(sql='select id, name from zones where region_id={region_id}', where={'region_id': 1})

[mathieuripert]

:(

[mathieuripert]

i dont think it is intuitive to have the where argument as it could be any type of arguments

[mathieuripert]

at least params instead of where. but i liked the ability to pass the named arguments directly

[neutralino1]

It is the same argument as when doing a select, update, delete...
We can change that but I think that's beyond the scope of this PR.
The syntax you propose would add a lot of conflicts to the rest of the API, namely what happens if the table has columns with names equal to SQL keywords (join, insert, limit...)?
Only the insert method follows the pattern you propose:

Zones.insert(name='Paris', region_id=100)

because there are no WHERE clause in the INSERT command.

[neutralino1]

Yes we could name it params, and store it as kwargs['where'] inside the method so that the downstream API keeps working. That works for me.

[mathieuripert]

vendu pour params 👍