Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Update google object storage library #66

Closed
cin opened this issue Aug 9, 2022 · 4 comments
Closed

[BUG] Update google object storage library #66

cin opened this issue Aug 9, 2022 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@cin
Copy link
Contributor

cin commented Aug 9, 2022

Describe the bug
A vulnerability in google's object storage library is causing Trivy to trip up and fail our CI/CD builds. Given the way this library is pulled in, I think simply building a new release will resolve this problem (since the version's not pinned in the maven pom file). We also need to rebuild icarus with the new esop version to squash the vulnerability in icarus as well.

https://avd.aquasec.com/nvd/2020/cve-2020-7692/

┌──────────────────────────────────────────────────────────┬───────────────┬──────────┬───────────────────┬───────────────┬──────────────────────────────────────────────────────────────┐
│                         Library                          │ Vulnerability │ Severity │ Installed Version │ Fixed Version │                            Title                             │
├──────────────────────────────────────────────────────────┼───────────────┼──────────┼───────────────────┼───────────────┼──────────────────────────────────────────────────────────────┤
│ com.google.oauth-client:google-oauth-client (icarus.jar) │ CVE-2020-7692 │ CRITICAL │ 1.30.5            │ 1.31.0        │ google-oauth-client: missing PKCE support in accordance with │
│                                                          │               │          │                   │               │ the RFC for OAuth 2.0...                                     │
│                                                          │               │          │                   │               │ https://avd.aquasec.com/nvd/cve-2020-7692                    │
└──────────────────────────────────────────────────────────┴───────────────┴──────────┴───────────────────┴───────────────┴──────────────────────────────────────────────────────────────┘

To Reproduce
Use icarus or esop with Trivy as a vulnerability scanner.

Expected behavior
No vulnerabilities

@cin cin added the bug Something isn't working label Aug 9, 2022
@smiklosovic
Copy link
Collaborator

@cin do you want me to release it or you are able to scan this and verify it is ok by building it yourself from master branch?

@cin
Copy link
Contributor Author

cin commented Aug 10, 2022

We haven't explicitly tested against Trivy yet, but one of my coworkers verified it's pulling in a secure version through the dependency tree output.

~/d/esop> mvn dependency:tree -Dincludes=com.google.oauth-client
[INFO] Scanning for projects...
[INFO]
[INFO] ------------------------< com.instaclustr:esop >------------------------
[INFO] Building instaclustr-esop 2.0.4-SNAPSHOT
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- maven-dependency-plugin:2.8:tree (default-cli) @ esop ---
[INFO] com.instaclustr:esop:jar:2.0.4-SNAPSHOT
[INFO] \- com.google.cloud:google-cloud-storage:jar:1.118.1:compile
[INFO]    \- com.google.oauth-client:google-oauth-client:jar:1.31.5:compile
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  1.835 s
[INFO] Finished at: 2022-08-09T17:31:29+03:00
[INFO] ------------------------------------------------------------------------

@smiklosovic
Copy link
Collaborator

I ve just released 2.0.4. I guess I need to align this to Icarus as well.

@smiklosovic
Copy link
Collaborator

Icarus is released too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants