Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quickstart notebbok: Run Multi-Agent DDPG System. #290

Closed
jbakams opened this issue Aug 6, 2021 · 9 comments
Closed

Quickstart notebbok: Run Multi-Agent DDPG System. #290

jbakams opened this issue Aug 6, 2021 · 9 comments
Assignees
Labels
bug Something isn't working

Comments

@jbakams
Copy link

jbakams commented Aug 6, 2021

I was playing around with the quickstart notebook but having this error on Run Multi-Agent DDPG System (I tried locally and on colab):

UnparsedFlagAccessError: Trying to access flag --lp_termination_notice_secs before flags were parsed.

@KaleabTessera
Copy link
Contributor

Hi @jbakambana, thanks for pointing this out. This was related to an issue with an external library that we use for scaling google-deepmind/launchpad#14 .

We have a PR out for this fix (#291). I will let you know when to test this again.

@arnupretorius
Copy link
Collaborator

Hi @jbakambana, the PR for the fix has been merged. The notebook should work again now 😄

Please let us know if there are still any issues. Thanks again for pointing this out!

@jbakams
Copy link
Author

jbakams commented Aug 9, 2021

Hi @arnupretorius , thanks for your feedback. The notebook is working now on colab. But the problem remains when I tried with Desktop even though I reinstalled Mava.

@KaleabTessera
Copy link
Contributor

@jbakambana Try printing out your version of launchpad like, pip show dm-launchpad-nightly.

It should be 0.3.0.dev20210730. It it isn't, it means the re-install failed for some reason. Please confirm that you have the latest setup.py when you re-installed Mava?

@jbakams
Copy link
Author

jbakams commented Aug 9, 2021

I got this: Version: 0.3.0.dev20210809. How do I check for the setup.py file?

.

@KaleabTessera
Copy link
Contributor

@jbakambana If you are on the develop branch, please do a pull from master (git pull). That should pull an updated setup.py file. Then after that, re-installing Mava should work.

@jbakams
Copy link
Author

jbakams commented Aug 10, 2021

Thank you @KaleabTessera it's ok now!

@jbakams jbakams closed this as completed Aug 10, 2021
@KaleabTessera
Copy link
Contributor

My recent PR retroduced this, I am fixing this to work with latest LP.

@KaleabTessera KaleabTessera reopened this Aug 17, 2021
@KaleabTessera
Copy link
Contributor

Looks fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants