Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account for Decorators in AwaitAsyncCallRule #114

Closed
josieesh opened this issue Sep 4, 2020 · 0 comments
Closed

Account for Decorators in AwaitAsyncCallRule #114

josieesh opened this issue Sep 4, 2020 · 0 comments

Comments

@josieesh
Copy link
Contributor

josieesh commented Sep 4, 2020

Currently we exit early if the type is not a Callable: https://github.com/Instagram/Fixit/blob/master/fixit/rules/await_async_call.py#L296
But this means we don't catch coroutines that are decorated such as classmethod, staticmethod, etc
Eg a class method's reported Pyre type is:

typing.ClassMethod[typing.Callable(...)[[...], typing.Coroutine[...]]]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amyreese @josieesh