-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show a better warning for missing pyre dependency #132
Comments
The problem is that, on |
Some rules rely on Pyre to provide inferred type (e.g. AwaitAsyncCallRule) to work. Fixit/fixit/rules/await_async_call.py Line 16 in 18365db
Missing Pyre doesn't impact the use of Fixit. Flake8 is included in Fixit via Flake8PseudoLintRule. So Fixit actually work fine on your example code. There was no other suggestions from Fixit specific rules. Closing this since there is real no issue. |
Wouldn't it be more feasible (especially targeted for new users who have no idea about this, since most linters don't require additional type-checkers to start in that same environment) to ignore this errors, and just give a couple of warnings at the end. Current:
IMHO a better:
|
That makes sense especially Pyre is not listed as required dependency of Fixit. |
Hey folks, we just released Fixit 2.0, which includes major changes to the core frameworks, linting engine, API, and CLI. In light of this new release, this issue is likely to be resolved or no longer relevant. Please take a look at the new user guide or the upgrade guide for more information on how to migrate your projects to the new version. If you believe this issue is still relevant or still occurring in the latest version, please feel free to open a new issue, or reply here with more details. Thank you! |
When running fixit I encountered the following error:
My example project has a single python file,
main.py
, with the following content:Here's the repository for reference: https://github.com/chdsbd/fixit-example
Unrelated, but I was surprised to see messages about pyre and flake8. Can fixit be run without these?
The text was updated successfully, but these errors were encountered: