Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatter? #257

Closed
eggplants opened this issue Mar 23, 2022 · 3 comments · Fixed by #258
Closed

Formatter? #257

eggplants opened this issue Mar 23, 2022 · 3 comments · Fixed by #258

Comments

@eggplants
Copy link
Contributor

I suggest to introduce black like libcst and isort.

@carljm
Copy link
Contributor

carljm commented Mar 23, 2022

Introducing black and isort sounds good to me!

Not sure how libcst is relevant here; MonkeyType does already depend on libcst for monkeytype apply, but that's not related to formatting MonkeyType's own code.

@eggplants
Copy link
Contributor Author

Not sure how libcst is relevant here

When I thought about what formatter to adopt, I found that libcst uses black and suggested it.

black==18.4a2

@carljm
Copy link
Contributor

carljm commented Mar 23, 2022

Sorry, my reading comprehension fail -- you said "black like libcst", I read it as a "black and libcst and isort" :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants