-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pep_563 flag creates imports that don't match the usage of the name #313
Comments
I'm not able to reproduce the results you show. Using Python 3.12 and the latest MonkeyType and the code in your gist (after
This is buggy (because the annotations use I'll look into fixing the bug I observe; let me know if you have any further theories about what I should try to reproduce your results. It might be related to the LibCST version; I'm using |
Confirmed that working with the current release of Monkeytype and |
I don't, I'm inclined to just reopen this issue and use it, since it's the same repro case (albeit different output.) When you say "everything's fine on this issue," do you mean that you observe the same output I did (which is not exactly "fine" but it isn't as bad as what you got), or do you mean that you actually observe fully-working output? |
I meant that I'm observing the same output as you do, I'm also running into fun issues with ellipses not having qualnames in the serialization phase that I'm trying to get a replication of for you, I have a fork that adds in a branch to account for it but it's a hacky fix for a problem that I can't replicate on another computer. |
Running
monkeytype run NumPyCNN.py; monkeytype apply extracted_conv_
on this gist produces irregular imports, which look like this:The text was updated successfully, but these errors were encountered: