Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlights ending with ... has a missing folder/file error #710

Open
mlalcevski opened this issue Jun 29, 2020 · 3 comments
Open

Highlights ending with ... has a missing folder/file error #710

mlalcevski opened this issue Jun 29, 2020 · 3 comments
Labels
bug Bug leave open Not closed automatically due to inactivity

Comments

@mlalcevski
Copy link

Describe the bug
One of the highlights is labeled "Something ...", the "..." does not work as a folder name in windows so it gets an error every time.

To Reproduce
Download any highlights ending in ...

Expected behavior
Well rename the folder and ignore the ..

Error messages and tracebacks
[Errno 2] No such file or directory

Instaloader version
4.4.4

Additional context

@mlalcevski mlalcevski added the bug Bug label Jun 29, 2020
@aandergr
Copy link
Member

aandergr commented Jul 4, 2020

Thanks for reporting. Indeed, creating a folder containing ".." or "..." in the name does not always work on Windows.

Expected behavior
Well rename the folder and ignore the ..

Maybe the dots in "..." should be replaced by another character that is not invalid in filenames and does not collide with characters that might occur in highlight titles, such as "-". There is also #576 with an idea of how we could approach this.

@psonnosp
Copy link

It just does not always work, it never works with dots at the end of a folder name in Windows.
I know nothing about whats talked about in that other issue, but is it a complicated thing to make Instaloader ignore dots or use _ instead in the ending of folder names? Cause this seems like kind of a basic thing to handle for a program that runs in Windows.

@psonnosp
Copy link

If this can't be fixed by replacing the dots would it be possible to make instaloader at least continue and not just quit with this error?
...\2019-05-23_11-39-37_UTC_cover.jpg Traceback (most recent call last):
File "main.py", line 462, in
File "main.py", line 459, in __main
File "main.py", line 429, in main
File "main.py", line 203, in _main
File "instaloader\instaloader.py", line 1150, in download_profiles
File "instaloader\instaloader.py", line 63, in call
File "instaloader\instaloader.py", line 708, in download_highlights
File "instaloader\instaloader.py", line 429, in download_highlight_cover
File "instaloader\instaloader.py", line 79, in call
File "instaloader\instaloader.py", line 416, in download_title_pic
File "instaloader\instaloadercontext.py", line 485, in write_raw
FileNotFoundError: [Errno 2] No such file or directory: ...\2019-05-23_11-39-37_UTC_cover.jpg.temp'
[18116] Failed to execute script main

@github-actions github-actions bot added the stale Issue is inactive for a long time label Nov 16, 2020
@aandergr aandergr added leave open Not closed automatically due to inactivity and removed stale Issue is inactive for a long time labels Nov 21, 2020
@aandergr aandergr linked a pull request Mar 15, 2022 that will close this issue
@github-actions github-actions bot added the stale Issue is inactive for a long time label May 19, 2024
@aandergr aandergr removed the stale Issue is inactive for a long time label May 20, 2024
@instaloader instaloader deleted a comment from github-actions bot May 20, 2024
@instaloader instaloader deleted a comment from github-actions bot May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug leave open Not closed automatically due to inactivity
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants