Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stream freezes when sequence is rewritten to 0 #12

Open
stoically opened this issue Mar 17, 2019 · 1 comment
Open

Stream freezes when sequence is rewritten to 0 #12

stoically opened this issue Mar 17, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@stoically
Copy link
Contributor

A side-effect of self._seq and self._wasAd keeping their values when switching streams (through xhr website-navigation which doesnt reload the wasmworker) is that the sequence can "always" get set to 0 - if the sequence of the new stream is smaller than the already set _seq - resulting in a stream-freeze (even if no Ad plays).

@instance01
Copy link
Owner

Good catch, maybe hook into the router and just reset on each change.
Or, probably much easier, add onClick listeners to the affected elements (I'd say sidebar and when browsing channels).

@instance01 instance01 added the bug Something isn't working label Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants