Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t.target.closest is not a function #23

Closed
PikachuEXE opened this issue Mar 1, 2019 · 3 comments
Closed

t.target.closest is not a function #23

PikachuEXE opened this issue Mar 1, 2019 · 3 comments

Comments

@PikachuEXE
Copy link

https://github.com/instantpage/instant.page/blob/v1.2.1/instantpage.js#L52

Most of them are from Chrome 59+ / Edge 17.17134
Which should support Element.closest

I do plan to add polyfill for Element.closest
but I don't think it's related to most browsers that raises this error for us

@dieulot
Copy link
Member

dieulot commented Mar 15, 2019

Could you link to a page where this happens? Do you know on which links this happens?

@PikachuEXE
Copy link
Author

I can't reproduce it locally
And I cannot enable it on production until there is [whitelist mode](#18 is added)

Maybe whitelisting only certain links (common navbar/footer, frequently used link buttons...)
would solve this issue for us as well

No way to tell what's causing it for now
Let me reopen this issue once I got similar error reports again

@dieulot
Copy link
Member

dieulot commented Jul 1, 2022

This is fixed (with a check on event.target.closest) in v5.1.1. 00249af

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants