Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error Handling and Logging #51

Open
dtext opened this issue Apr 21, 2017 · 0 comments
Open

Error Handling and Logging #51

dtext opened this issue Apr 21, 2017 · 0 comments

Comments

@dtext
Copy link
Member

dtext commented Apr 21, 2017

After Milestone 0.2, we should rethink error handling and logging inside the storage providers. They also need to be resilient in the face of failure. For example, errors we don't anticipate are:

  • no internet connection
  • unsupported media type for hoster
  • upload failed for some other reason
  • API change
  • ...

If I call an upload(file) method, I expect an error to be raised when that method does not complete successfully. That error could then be handled by me, the individual storage providers don't need to be concerned about how to inform the user about errors.

There was a change a while back where the storage provider's functionality was moved up to the module level for the sake of simplicity. Now I think it could be better to think about storage providers as classes with state again. I believe that would make them more maintainable.

p.s.: This is labeled as a bug because the any of the listed errors has the potential to crash the storage provider modules.

@dtext dtext added this to the Version 1.0 milestone Jun 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant