Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement Slack component #120

Merged
merged 12 commits into from
May 14, 2024
Merged

feat: implement Slack component #120

merged 12 commits into from
May 14, 2024

Conversation

chuang8511
Copy link
Member

@chuang8511 chuang8511 commented May 13, 2024 •
edited by donch1989

Because

  • We'd like to introduce a new component connector to Slack.

This commit

  • Implements first stage of Slack component, including
    • Read task to retrieve the messages from Slack.
    • Write task to send the message to Slack.

@linear Linear
Copy link

linear bot commented May 13, 2024

INS-4298 Support Slack component

@chuang8511
Copy link
Member Author

test failed because there is 1 hour time difference between local and GitHub action.
I will fix it later with the mock system.

donch1989
donch1989 requested changes May 13, 2024
View reviewed changes
pkg/connector/slack/v0/config/tasks.json Show resolved Hide resolved
pkg/connector/slack/v0/apiFunctions.go Outdated Show resolved Hide resolved
pkg/connector/slack/v0/connector_test.go Outdated Show resolved Hide resolved
pkg/connector/slack/v0/connector_test.go Outdated Show resolved Hide resolved
pkg/connector/slack/v0/apiFunctions.go Outdated Show resolved Hide resolved
@donch1989
Copy link
Member

donch1989 commented May 13, 2024 •
edited

BTW, I suggest change the title to feat: implement Slack component
The content should mention that which two tasks we implemented.

@chuang8511 chuang8511 changed the title feat: slack component for first stage feat: implement Slack component May 13, 2024
@chuang8511 chuang8511 requested a review from donch1989 May 14, 2024 08:55
@donch1989 donch1989 merged commit 1ecff8a into main May 14, 2024
9 checks passed
@donch1989 donch1989 deleted the chunhao/ins-4298-2 branch May 14, 2024 10:21
@droplet-bot droplet-bot mentioned this pull request May 14, 2024
Merged
donch1989 pushed a commit that referenced this pull request May 16, 2024
@droplet-bot
chore(main): release 0.17.0-beta (#111)
5dc960d 
🤖 I have created a release *beep* *boop*
---


##
[0.17.0-beta](v0.16.0-beta...v0.17.0-beta)
(2024-05-15)


### Features

* add additional attribute in JSON schema for Instill Credit
([#118](#118))
([a6751fa](a6751fa))
* add global secrets to StabilityAI connector
([#122](#122))
([1db0c9f](1db0c9f))
* add sourceTag for pinecone
([#117](#117))
([b202da1](b202da1))
* allow global API key on OpenAI connector
([#110](#110))
([42bccdd](42bccdd))
* implement Slack component
([#120](#120))
([1ecff8a](1ecff8a))
* **openai:** support gpt-4o model
([#127](#127))
([536f5af](536f5af))
* update Instill Credit supported model list
([#123](#123))
([0b0cf81](0b0cf81))


### Bug Fixes

* Fix the bug of setting channelID
([#125](#125))
([47bc192](47bc192))
* **slack:** add `instillSecret: true` to `token` field
([#126](#126))
([7751585](7751585))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donch1989 donch1989 donch1989 requested changes

@pinglin pinglin Awaiting requested review from pinglin pinglin is a code owner

@xiaofei-du xiaofei-du Awaiting requested review from xiaofei-du xiaofei-du is a code owner

@jvallesm jvallesm Awaiting requested review from jvallesm jvallesm is a code owner

Assignees
No one assigned
Labels
instill vdp
Projects
🔮 Instill Core
Status: 👋 Done
Milestone
No milestone
3 participants
@chuang8511 @donch1989 @droplet-bot