feat: refactor package structure #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: The compogen test won't pass on CI because we need to update the hash for the component repository in go.mod. |
jvallesm
reviewed
May 27, 2024
There was a problem hiding this comment.
Perhaps we can ask @GeorgeWilliamStrong to proofread this, see if there are points where we can improve clarity.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #140 +/- ##
==========================================
+ Coverage 57.32% 58.59% +1.26%
==========================================
Files 30 36 +6
Lines 3145 3437 +292
==========================================
+ Hits 1803 2014 +211
- Misses 1104 1157 +53
- Partials 238 266 +28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Yes, I'll update the website to adopt these changes. |
Merged
chuang8511
pushed a commit
that referenced
this pull request
May 28, 2024
Because - In our new VDP recipe design, there is not much difference between connectors and operators, and the term "connector" doesn't provide useful information to the user. Therefore, we decided to flatten the component structure. The original connectors will be directly categorized into `ai`, `data`, and `application` components. This commit - Modifies the folder structure to categorize connectors into `ai`, `data`, and `application` components. - Removes `/pkg` folder. Note - In this PR, we only modify the folder structure. In the upcoming PRs, we'll further refactor the component interface to unify the connector and operator interfaces into one component interface.
donch1989
pushed a commit
that referenced
this pull request
Jun 6, 2024
🤖 I have created a release *beep* *boop* --- ## [0.19.0-beta](v0.18.0-beta...v0.19.0-beta) (2024-06-05) ### Features * add pdf component ([#138](#138)) ([517afcf](517afcf)) * add task chunk text ([#139](#139)) ([7b36553](7b36553)) * **instill:** adopt latest Model endpoints ([#146](#146)) ([7f2537b](7f2537b)) * optimise ux for slack component ([#143](#143)) ([ed60235](ed60235)) * refactor package structure ([#140](#140)) ([4853d4c](4853d4c)) * support markdown to text function in text operator ([#149](#149)) ([dcbae37](dcbae37)) * unify component interface ([#144](#144)) ([ad35e10](ad35e10)) ### Bug Fixes * bug of failure of document component ([#152](#152)) ([aed51f8](aed51f8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
namwoam
pushed a commit
to namwoam/component
that referenced
this pull request
Jun 24, 2024
Because - In our new VDP recipe design, there is not much difference between connectors and operators, and the term "connector" doesn't provide useful information to the user. Therefore, we decided to flatten the component structure. The original connectors will be directly categorized into `ai`, `data`, and `application` components. This commit - Modifies the folder structure to categorize connectors into `ai`, `data`, and `application` components. - Removes `/pkg` folder. Note - In this PR, we only modify the folder structure. In the upcoming PRs, we'll further refactor the component interface to unify the connector and operator interfaces into one component interface.
namwoam
pushed a commit
to namwoam/component
that referenced
this pull request
Jun 24, 2024
🤖 I have created a release *beep* *boop* --- ## [0.19.0-beta](instill-ai/component@v0.18.0-beta...v0.19.0-beta) (2024-06-05) ### Features * add pdf component ([instill-ai#138](instill-ai#138)) ([517afcf](instill-ai@517afcf)) * add task chunk text ([instill-ai#139](instill-ai#139)) ([7b36553](instill-ai@7b36553)) * **instill:** adopt latest Model endpoints ([instill-ai#146](instill-ai#146)) ([7f2537b](instill-ai@7f2537b)) * optimise ux for slack component ([instill-ai#143](instill-ai#143)) ([ed60235](instill-ai@ed60235)) * refactor package structure ([instill-ai#140](instill-ai#140)) ([4853d4c](instill-ai@4853d4c)) * support markdown to text function in text operator ([instill-ai#149](instill-ai#149)) ([dcbae37](instill-ai@dcbae37)) * unify component interface ([instill-ai#144](instill-ai#144)) ([ad35e10](instill-ai@ad35e10)) ### Bug Fixes * bug of failure of document component ([instill-ai#152](instill-ai#152)) ([aed51f8](instill-ai@aed51f8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
ai,data, andapplicationcomponents.This commit
ai,data, andapplicationcomponents./pkgfolder.Note