feat: unify component interface #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donch1989
force-pushed
the
huitang/ins-4680
branch
from
a870dbe
to
5952a77
Compare
donch1989
force-pushed
the
huitang/ins-4680
branch
from
53be22c
to
ba09fe5
Compare
donch1989
pushed a commit
that referenced
this pull request
Jun 6, 2024
🤖 I have created a release *beep* *boop* --- ## [0.19.0-beta](v0.18.0-beta...v0.19.0-beta) (2024-06-05) ### Features * add pdf component ([#138](#138)) ([517afcf](517afcf)) * add task chunk text ([#139](#139)) ([7b36553](7b36553)) * **instill:** adopt latest Model endpoints ([#146](#146)) ([7f2537b](7f2537b)) * optimise ux for slack component ([#143](#143)) ([ed60235](ed60235)) * refactor package structure ([#140](#140)) ([4853d4c](4853d4c)) * support markdown to text function in text operator ([#149](#149)) ([dcbae37](dcbae37)) * unify component interface ([#144](#144)) ([ad35e10](ad35e10)) ### Bug Fixes * bug of failure of document component ([#152](#152)) ([aed51f8](aed51f8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
namwoam
pushed a commit
to namwoam/component
that referenced
this pull request
Jun 24, 2024
Because - We decided to remove the connector and operator categorization and organize the components into AI, data, application, and operator components. The original `IConnector` and `IOperator` interfaces are no longer needed. - We had a `connection` field for the connectors to set up the connection. To make this term more general, we renamed it to `setup`. The `setup` field should be applicable to all kinds of components. For example, for a CPU-bound operator, we might need to configure some hardware resources in the future. This configuration can also be placed in the `setup` field. Additionally, to improve the readability of the JSON file, we moved the configuration into a new `setup.json` file. - We are going to recategorize `googlesearch`, `redis`, `restapi`, and `website` into the "application" component. This commit - Removes the base connector and operator interfaces and structs. Moves all functions to the base component struct. - Moves all `connection` properties into a new `setup.json` file. - Bumps the component version of `googlesearch`, `redis`, `restapi`, and `website` to make the component type updated. - Moves the `component.go` file into a new package `/store`.
namwoam
pushed a commit
to namwoam/component
that referenced
this pull request
Jun 24, 2024
🤖 I have created a release *beep* *boop* --- ## [0.19.0-beta](instill-ai/component@v0.18.0-beta...v0.19.0-beta) (2024-06-05) ### Features * add pdf component ([instill-ai#138](instill-ai#138)) ([517afcf](instill-ai@517afcf)) * add task chunk text ([instill-ai#139](instill-ai#139)) ([7b36553](instill-ai@7b36553)) * **instill:** adopt latest Model endpoints ([instill-ai#146](instill-ai#146)) ([7f2537b](instill-ai@7f2537b)) * optimise ux for slack component ([instill-ai#143](instill-ai#143)) ([ed60235](instill-ai@ed60235)) * refactor package structure ([instill-ai#140](instill-ai#140)) ([4853d4c](instill-ai@4853d4c)) * support markdown to text function in text operator ([instill-ai#149](instill-ai#149)) ([dcbae37](instill-ai@dcbae37)) * unify component interface ([instill-ai#144](instill-ai#144)) ([ad35e10](instill-ai@ad35e10)) ### Bug Fixes * bug of failure of document component ([instill-ai#152](instill-ai#152)) ([aed51f8](instill-ai@aed51f8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
IConnectorandIOperatorinterfaces are no longer needed.connectionfield for the connectors to set up the connection. To make this term more general, we renamed it tosetup. Thesetupfield should be applicable to all kinds of components. For example, for a CPU-bound operator, we might need to configure some hardware resources in the future. This configuration can also be placed in thesetupfield. Additionally, to improve the readability of the JSON file, we moved the configuration into a newsetup.jsonfile.googlesearch,redis,restapi, andwebsiteinto the "application" component.This commit
connectionproperties into a newsetup.jsonfile.googlesearch,redis,restapi, andwebsiteto make the component type updated.component.gofile into a new package/store.