fix(vdp): better casting errors #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #65 +/- ##
==========================================
- Coverage 46.25% 45.59% -0.66%
==========================================
Files 6 6
Lines 1120 1136 +16
==========================================
Hits 518 518
- Misses 513 529 +16
Partials 89 89
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
donch1989
pushed a commit
that referenced
this pull request
Mar 12, 2024
🤖 I have created a release *beep* *boop* --- ## [0.13.0-beta](v0.12.0-beta...v0.13.0-beta) (2024-03-07) ### Features * expose description field in component entities ([#62](#62)) ([85bbc22](85bbc22)) * simplify `openapi_specifications` to `data_specifications` ([#64](#64)) ([7c27d15](7c27d15)) ### Bug Fixes * **vdp:** better casting errors ([#65](#65)) ([81e34c4](81e34c4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
namwoam
pushed a commit
to namwoam/component
that referenced
this pull request
Jun 24, 2024
Because - `description` field in operator is now in imperative format - When a connector / operator definition is fetched, it is pulled from the component definition list. When an error occurs, we can't know if it's because it doesn't exist or because the type is wrong. This commit - Updates `compogen` tests - Improves the error messages for the "get by ID / UID" component definition methods.
namwoam
pushed a commit
to namwoam/component
that referenced
this pull request
Jun 24, 2024
🤖 I have created a release *beep* *boop* --- ## [0.13.0-beta](instill-ai/component@v0.12.0-beta...v0.13.0-beta) (2024-03-07) ### Features * expose description field in component entities ([instill-ai#62](instill-ai#62)) ([85bbc22](instill-ai@85bbc22)) * simplify `openapi_specifications` to `data_specifications` ([instill-ai#64](instill-ai#64)) ([7c27d15](instill-ai@7c27d15)) ### Bug Fixes * **vdp:** better casting errors ([instill-ai#65](instill-ai#65)) ([81e34c4](instill-ai@81e34c4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
descriptionfield in operator is now in imperative formatThis commit
compogentests