Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: merge connector and operator repos into this repo #72

Merged
merged 10 commits into from
Mar 20, 2024

Conversation

donch1989
Copy link
Member

@donch1989 donch1989 commented Mar 19, 2024

Because

  • As our project expands to include various component types such as generic, iterator, and AI components, managing separate repositories for each becomes less practical. Although the initial plan aimed to integrate them directly into the component repository, the introduction of the new AI Component poses challenges. Given that the AI Component relies on the implementation of all connectors in the connector repository, including it in the component repository would lead to cyclic dependencies. Therefore, the optimal solution is to consolidate all components into a single repository.

This commit

  • Merges code from connector and operator into this repository.
  • Removes unused objectmapper.

Copy link

linear bot commented Mar 19, 2024

@donch1989 donch1989 marked this pull request as draft March 19, 2024 08:46
pkg/connector/instill/v0/client.go Dismissed Show dismissed Hide dismissed
pkg/connector/instill/v0/client.go Dismissed Show dismissed Hide dismissed
pkg/connector/redis/v0/client.go Dismissed Show dismissed Hide dismissed
pkg/connector/restapi/v0/auth.go Dismissed Show dismissed Hide dismissed
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 60.73059% with 602 lines in your changes are missing coverage. Please review.

Project coverage is 57.40%. Comparing base (94c126f) to head (ecbf050).

Files Patch % Lines
pkg/connector/huggingface/v0/main.go 57.71% 120 Missing and 50 partials ⚠️
pkg/connector/openai/v0/main.go 57.95% 92 Missing and 11 partials ⚠️
pkg/connector/restapi/v0/main.go 49.57% 52 Missing and 8 partials ⚠️
pkg/operator/base64/v0/main.go 9.25% 48 Missing and 1 partial ⚠️
pkg/connector/stabilityai/v0/image_to_image.go 55.76% 30 Missing and 16 partials ⚠️
pkg/connector/util/helper.go 5.26% 36 Missing ⚠️
pkg/connector/archetypeai/v0/main.go 75.91% 22 Missing and 11 partials ⚠️
pkg/connector/restapi/v0/auth.go 33.33% 20 Missing and 4 partials ⚠️
pkg/connector/pinecone/v0/main.go 74.07% 15 Missing and 6 partials ⚠️
pkg/connector/stabilityai/v0/main.go 78.31% 12 Missing and 6 partials ⚠️
... and 5 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #72       +/-   ##
===========================================
+ Coverage   44.94%   57.40%   +12.46%     
===========================================
  Files           6       30       +24     
  Lines        1117     3141     +2024     
===========================================
+ Hits          502     1803     +1301     
- Misses        527     1098      +571     
- Partials       88      240      +152     
Flag Coverage Δ
unittests 57.40% <60.73%> (+12.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@donch1989 donch1989 marked this pull request as ready for review March 19, 2024 10:06
Copy link
Collaborator

@jvallesm jvallesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments about the references to the (now local) connector and operator packages.

👍 I think this is a good move, connector and operator exist under the component umbrella and, though it makes sense to decouple the implementation of each component from the interfaces it should comply with, it doesn't justify the complexity of maintaining 3 repos.

.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
tools/compogen/go.sum Outdated Show resolved Hide resolved
donch1989 and others added 5 commits March 20, 2024 12:58
Co-authored-by: Juan Vallés <3977183+jvallesm@users.noreply.github.com>
Co-authored-by: Juan Vallés <3977183+jvallesm@users.noreply.github.com>
Co-authored-by: Juan Vallés <3977183+jvallesm@users.noreply.github.com>
Co-authored-by: Juan Vallés <3977183+jvallesm@users.noreply.github.com>
Co-authored-by: Juan Vallés <3977183+jvallesm@users.noreply.github.com>
@donch1989
Copy link
Member Author

@jvallesm Thanks for the detailed review!

@donch1989 donch1989 merged commit 2fd6b1d into main Mar 20, 2024
10 checks passed
@donch1989 donch1989 deleted the huitang/ins-3793 branch March 20, 2024 08:26
donch1989 pushed a commit that referenced this pull request Mar 29, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.14.0-beta](v0.13.0-beta...v0.14.0-beta)
(2024-03-29)


### Features

* document release stages and versions
([#70](#70))
([91457dc](91457dc))
* merge connector and operator repos into this repo
([#72](#72))
([2fd6b1d](2fd6b1d))
* read release stage in auto generated docs from field in definitions
([#68](#68))
([90ea333](90ea333))
* remove pre-release label in version
([#75](#75))
([f0320d3](f0320d3))


### Bug Fixes

* document pre-release version removal
([#71](#71))
([e527a11](e527a11))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
namwoam pushed a commit to namwoam/component that referenced this pull request Jun 24, 2024
Because
- As our project expands to include various component types such as
generic, iterator, and AI components, managing separate repositories for
each becomes less practical. Although the initial plan aimed to
integrate them directly into the component repository, the introduction
of the new AI Component poses challenges. Given that the AI Component
relies on the implementation of all connectors in the connector
repository, including it in the component repository would lead to
cyclic dependencies. Therefore, the optimal solution is to consolidate
all components into a single repository.

This commit

- Merges code from [connector](https://github.com/instill-ai/connector)
and [operator](https://github.com/instill-ai/operator) into this
repository.
- Removes unused `objectmapper`.

---------

Co-authored-by: Juan Vallés <3977183+jvallesm@users.noreply.github.com>
namwoam pushed a commit to namwoam/component that referenced this pull request Jun 24, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.14.0-beta](instill-ai/component@v0.13.0-beta...v0.14.0-beta)
(2024-03-29)


### Features

* document release stages and versions
([instill-ai#70](instill-ai#70))
([91457dc](instill-ai@91457dc))
* merge connector and operator repos into this repo
([instill-ai#72](instill-ai#72))
([2fd6b1d](instill-ai@2fd6b1d))
* read release stage in auto generated docs from field in definitions
([instill-ai#68](instill-ai#68))
([90ea333](instill-ai@90ea333))
* remove pre-release label in version
([instill-ai#75](instill-ai#75))
([f0320d3](instill-ai@f0320d3))


### Bug Fixes

* document pre-release version removal
([instill-ai#71](instill-ai#71))
([e527a11](instill-ai@e527a11))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
3 participants