-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: merge connector and operator repos into this repo #72
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #72 +/- ##
===========================================
+ Coverage 44.94% 57.40% +12.46%
===========================================
Files 6 30 +24
Lines 1117 3141 +2024
===========================================
+ Hits 502 1803 +1301
- Misses 527 1098 +571
- Partials 88 240 +152
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments about the references to the (now local) connector and operator packages.
👍 I think this is a good move, connector and operator exist under the component umbrella and, though it makes sense to decouple the implementation of each component from the interfaces it should comply with, it doesn't justify the complexity of maintaining 3 repos.
Co-authored-by: Juan Vallés <3977183+jvallesm@users.noreply.github.com>
Co-authored-by: Juan Vallés <3977183+jvallesm@users.noreply.github.com>
Co-authored-by: Juan Vallés <3977183+jvallesm@users.noreply.github.com>
Co-authored-by: Juan Vallés <3977183+jvallesm@users.noreply.github.com>
Co-authored-by: Juan Vallés <3977183+jvallesm@users.noreply.github.com>
@jvallesm Thanks for the detailed review! |
🤖 I have created a release *beep* *boop* --- ## [0.14.0-beta](v0.13.0-beta...v0.14.0-beta) (2024-03-29) ### Features * document release stages and versions ([#70](#70)) ([91457dc](91457dc)) * merge connector and operator repos into this repo ([#72](#72)) ([2fd6b1d](2fd6b1d)) * read release stage in auto generated docs from field in definitions ([#68](#68)) ([90ea333](90ea333)) * remove pre-release label in version ([#75](#75)) ([f0320d3](f0320d3)) ### Bug Fixes * document pre-release version removal ([#71](#71)) ([e527a11](e527a11)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Because - As our project expands to include various component types such as generic, iterator, and AI components, managing separate repositories for each becomes less practical. Although the initial plan aimed to integrate them directly into the component repository, the introduction of the new AI Component poses challenges. Given that the AI Component relies on the implementation of all connectors in the connector repository, including it in the component repository would lead to cyclic dependencies. Therefore, the optimal solution is to consolidate all components into a single repository. This commit - Merges code from [connector](https://github.com/instill-ai/connector) and [operator](https://github.com/instill-ai/operator) into this repository. - Removes unused `objectmapper`. --------- Co-authored-by: Juan Vallés <3977183+jvallesm@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- ## [0.14.0-beta](instill-ai/component@v0.13.0-beta...v0.14.0-beta) (2024-03-29) ### Features * document release stages and versions ([instill-ai#70](instill-ai#70)) ([91457dc](instill-ai@91457dc)) * merge connector and operator repos into this repo ([instill-ai#72](instill-ai#72)) ([2fd6b1d](instill-ai@2fd6b1d)) * read release stage in auto generated docs from field in definitions ([instill-ai#68](instill-ai#68)) ([90ea333](instill-ai@90ea333)) * remove pre-release label in version ([instill-ai#75](instill-ai#75)) ([f0320d3](instill-ai@f0320d3)) ### Bug Fixes * document pre-release version removal ([instill-ai#71](instill-ai#71)) ([e527a11](instill-ai@e527a11)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Because
This commit
objectmapper
.