feat: adjust IConnector interface
#83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donch1989
requested review from
pinglin,
xiaofei-du and
jvallesm
as code owners
donch1989
pushed a commit
that referenced
this pull request
Apr 25, 2024
🤖 I have created a release *beep* *boop* --- ## [0.15.0-beta](v0.14.1-beta...v0.15.0-beta) (2024-04-25) ### Features * add `UsageHandler` interface ([#87](#87)) ([b9d9645](b9d9645)) * adjust `IConnector` interface ([#83](#83)) ([46ea796](46ea796)) * adjust `Test()` interface ([#81](#81)) ([763cc6d](763cc6d)) * adopt system variables ([#92](#92)) ([e8ae4e1](e8ae4e1)) * expose `IsCredentialField` interface ([#93](#93)) ([6cd2801](6cd2801)) * merge resource spec into component spec ([#86](#86)) ([a6de70e](a6de70e)) * **airbyte:** remove Airbyte connectors ([#88](#88)) ([ec770d6](ec770d62cf52fa099a9be6825432d76f0d211f4a))* * **compogen:** use jsonref when generating the README ([#99](#99)) ([ff49157](ff49157)) * **instill:** drop support for "external mode" ([#101](#101)) ([b0c091b](b0c091b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
namwoam
pushed a commit
to namwoam/component
that referenced
this pull request
Jun 24, 2024
Because - Originally, we had a `resourceConfig` parameter in the `GetConnectorDefinitionByID()` and `GetConnectorDefinitionByUID()` functions. Since we retired the connector resource, these two parameters are not needed. This commit - Removes the `resourceConfig` parameter.
namwoam
pushed a commit
to namwoam/component
that referenced
this pull request
Jun 24, 2024
🤖 I have created a release *beep* *boop* --- ## [0.15.0-beta](instill-ai/component@v0.14.1-beta...v0.15.0-beta) (2024-04-25) ### Features * add `UsageHandler` interface ([instill-ai#87](instill-ai#87)) ([b9d9645](instill-ai@b9d9645)) * adjust `IConnector` interface ([instill-ai#83](instill-ai#83)) ([46ea796](instill-ai@46ea796)) * adjust `Test()` interface ([instill-ai#81](instill-ai#81)) ([763cc6d](instill-ai@763cc6d)) * adopt system variables ([instill-ai#92](instill-ai#92)) ([e8ae4e1](instill-ai@e8ae4e1)) * expose `IsCredentialField` interface ([instill-ai#93](instill-ai#93)) ([6cd2801](instill-ai@6cd2801)) * merge resource spec into component spec ([instill-ai#86](instill-ai#86)) ([a6de70e](instill-ai@a6de70e)) * **airbyte:** remove Airbyte connectors ([instill-ai#88](instill-ai#88)) ([ec770d6](instill-ai@ec770d62cf52fa099a9be6825432d76f0d211f4a))* * **compogen:** use jsonref when generating the README ([instill-ai#99](instill-ai#99)) ([ff49157](instill-ai@ff49157)) * **instill:** drop support for "external mode" ([instill-ai#101](instill-ai#101)) ([b0c091b](instill-ai@b0c091b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
resourceConfigparameter in theGetConnectorDefinitionByID()andGetConnectorDefinitionByUID()functions. Since we retired the connector resource, these two parameters are not needed.This commit
resourceConfigparameter.