Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: some props of the model trigger payload had snake_case, fixed them to camelCase #1254

Merged
merged 3 commits into from
Jun 20, 2024

Conversation

orangecoloured
Copy link
Collaborator

Because

  • The model page still had snake_case strings

This commit

  • fix snake_case to camelCase

Copy link

📦 Next.js Bundle Analysis for instillai-console

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

📦 Next.js Bundle Analysis for instillai-console

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link
Member

@EiffelFly EiffelFly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orangecoloured There is only one thing we need to address in this PR

Copy link
Member

@EiffelFly EiffelFly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

📦 Next.js Bundle Analysis for instillai-console

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@orangecoloured orangecoloured changed the title fix: camelCase integration fix: some props of the model trigger payload had snake_case, fixed them to camelCase Jun 20, 2024
@orangecoloured orangecoloured merged commit 8da7b09 into main Jun 20, 2024
9 checks passed
@orangecoloured orangecoloured deleted the fix-model-camel-case branch June 20, 2024 07:41
@droplet-bot droplet-bot mentioned this pull request Jun 20, 2024
orangecoloured pushed a commit that referenced this pull request Jun 20, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>0.49.2-beta</summary>

##
[0.49.2-beta](v0.49.1-beta...v0.49.2-beta)
(2024-06-20)


### Bug Fixes

* some props of the model trigger payload had snake_case, fixed them to
camelCase ([#1254](#1254))
([8da7b09](8da7b09))
</details>

<details><summary>@instill-ai/toolkit: 0.94.3</summary>

##
[0.94.3](https://github.com/instill-ai/console/compare/@instill-ai/toolkit-v0.94.2...@instill-ai/toolkit-v0.94.3)
(2024-06-20)


### Bug Fixes

* some props of the model trigger payload had snake_case, fixed them to
camelCase ([#1254](#1254))
([8da7b09](8da7b09))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants