Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: further stabilize e2e test by removing the clean up function #356

Merged
merged 1 commit into from
Feb 21, 2023
Merged

feat: further stabilize e2e test by removing the clean up function #356

merged 1 commit into from
Feb 21, 2023

Conversation

EiffelFly
Copy link
Member

Because

  • Console is the last to test in make file and we test console separately in CI so we don't need to clean up the resource after test

This commit

  • further stabilize e2e test by removing the clean up function

@EiffelFly EiffelFly merged commit eb0e58c into main Feb 21, 2023
@EiffelFly EiffelFly deleted the update-e2e-tests branch February 21, 2023 16:25
@droplet-bot droplet-bot mentioned this pull request Feb 21, 2023
Merged
@xiaofei-du xiaofei-du mentioned this pull request Feb 23, 2023
Merged
This was referenced Apr 10, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinglin pinglin Awaiting requested review from pinglin pinglin is a code owner

@Phelan164 Phelan164 Awaiting requested review from Phelan164

@xiaofei-du xiaofei-du Awaiting requested review from xiaofei-du xiaofei-du is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@EiffelFly