Skip to content
This repository has been archived by the owner on Aug 24, 2023. It is now read-only.

fix: probe requests block thread #13

Merged
merged 2 commits into from
Apr 13, 2023

Conversation

heiruwu
Copy link
Member

@heiruwu heiruwu commented Apr 12, 2023

Because

  • avoid request block while probing

This commit

  • add nested threading in probing

@linear
Copy link

linear bot commented Apr 12, 2023

INS-424 multithread probing in controller

  • implement multithread probing in controller to avoid blocking request
  • resolve and etcd I/O issue

@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: -1.46 ⚠️

Comparison is base (f44bfbe) 14.82% compared to head (7dc7c10) 13.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
- Coverage   14.82%   13.36%   -1.46%     
==========================================
  Files           4        4              
  Lines         587      651      +64     
==========================================
  Hits           87       87              
- Misses        493      557      +64     
  Partials        7        7              
Flag Coverage Δ
unittests 13.36% <0.00%> (-1.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/service/connector.go 0.00% <0.00%> (ø)
pkg/service/model.go 0.00% <0.00%> (ø)
pkg/service/pipeline.go 0.00% <0.00%> (ø)
pkg/service/service.go 31.63% <0.00%> (-1.20%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@heiruwu heiruwu changed the title chore: update probe threading fix: probe request blocking thread Apr 12, 2023
@heiruwu heiruwu marked this pull request as ready for review April 12, 2023 17:42
@heiruwu heiruwu changed the title fix: probe request blocking thread fix: probe requests block thread Apr 13, 2023
@heiruwu heiruwu merged commit 0294b2a into main Apr 13, 2023
13 checks passed
@heiruwu heiruwu deleted the heiru/ins-424-multithread-probing-in-controller branch April 13, 2023 03:48
xiaofei-du pushed a commit that referenced this pull request Apr 15, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.1.1-alpha](v0.1.0-alpha...v0.1.1-alpha)
(2023-04-15)


### Bug Fixes

* probe requests block thread
([#13](#13))
([0294b2a](0294b2a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
1 participant