feat(pkg): use mgmtPB.Owner to embed the owner information #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #523 +/- ##
=====================================
Coverage 1.01% 1.02%
=====================================
Files 15 15
Lines 5689 5676 -13
=====================================
Hits 58 58
+ Misses 5623 5610 -13
Partials 8 8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
heiruwu
pushed a commit
that referenced
this pull request
Feb 29, 2024
🤖 I have created a release *beep* *boop* --- ## [0.23.0-alpha](v0.22.0-alpha...v0.23.0-alpha) (2024-02-28) ### Features * **pkg:** use mgmtPB.Owner to embed the owner information ([#523](#523)) ([37d5708](37d5708)) ### Bug Fixes * **handler,ray:** fix reconciliation model status and namespace ([#525](#525)) ([62a30b6](62a30b6)) * **redis:** delete redis key when errored ([#526](#526)) ([bb4e18d](bb4e18d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
heiruwu
pushed a commit
that referenced
this pull request
Mar 9, 2024
🤖 I have created a release *beep* *boop* --- ## [0.23.0-alpha](v0.22.0-alpha...v0.23.0-alpha) (2024-03-09) ### Features * **pkg:** use mgmtPB.Owner to embed the owner information ([#523](#523)) ([37d5708](37d5708)) ### Bug Fixes * **handler,ray:** fix reconciliation model status and namespace ([#525](#525)) ([62a30b6](62a30b6)) * **redis:** delete redis key when errored ([#526](#526)) ([bb4e18d](bb4e18d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
heiruwu
pushed a commit
that referenced
this pull request
Mar 9, 2024
🤖 I have created a release *beep* *boop* --- ## [0.23.0-alpha](v0.22.0-alpha...v0.23.0-alpha) (2024-03-09) ### Features * **pkg:** use mgmtPB.Owner to embed the owner information ([#523](#523)) ([37d5708](37d5708)) ### Bug Fixes * **handler,ray:** fix reconciliation model status and namespace ([#525](#525)) ([62a30b6](62a30b6)) * **redis:** delete redis key when errored ([#526](#526)) ([bb4e18d](bb4e18d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
heiruwu
pushed a commit
that referenced
this pull request
Mar 9, 2024
🤖 I have created a release *beep* *boop* --- ## [0.23.0-alpha](v0.22.0-alpha...v0.23.0-alpha) (2024-03-09) ### Features * **pkg:** use mgmtPB.Owner to embed the owner information ([#523](#523)) ([37d5708](37d5708)) ### Bug Fixes * **handler,ray:** fix reconciliation model status and namespace ([#525](#525)) ([62a30b6](62a30b6)) * **redis:** delete redis key when errored ([#526](#526)) ([bb4e18d](bb4e18d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
owner_nameandowner(structpb) to embed owner information for Console. However,owneris astructpb, and it is not well-formatted. Since we already have dedicated messages forUserandOrganization, we should utilize these messages.This commit
mgmtPB.Ownerto embed the owner information in pipeline and connector response whenview != VIEW_BASIC.