Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(endpoints): use camelCase for filter query string #603

Merged
merged 1 commit into from
Jun 17, 2024
Merged

feat(endpoints): use camelCase for filter query string #603

merged 1 commit into from
Jun 17, 2024

Conversation

donch1989
Copy link
Member

Because

  • We should use camelCase for query strings to align with the HTTP body.

This commit

  • Updates query strings filter and orderBy to use camelCase.

@linear Linear
Copy link

linear bot commented Jun 17, 2024

INS-4725 Refactor naming style to camelCase

@donch1989 donch1989 merged commit 23955e9 into main Jun 17, 2024
12 checks passed
@donch1989 donch1989 deleted the huitang/ins-4725-2 branch June 17, 2024 07:30
@droplet-bot droplet-bot mentioned this pull request Jun 17, 2024
Merged
heiruwu pushed a commit that referenced this pull request Jun 19, 2024
@droplet-bot
chore(main): release 0.25.0-alpha (#601)
9012905 
🤖 I have created a release *beep* *boop*
---


##
[0.25.0-alpha](v0.24.0-alpha...v0.25.0-alpha)
(2024-06-18)


### Features

* **endpoints:** use camelCase for `filter` query string
([#603](#603))
([23955e9](23955e9))
* **handler:** use camelCase for HTTP body
([#599](#599))
([70f6d9a](70f6d9a))
* **model:** support model tag
([#600](#600))
([ef87bc9](ef87bc9))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heiruwu heiruwu Awaiting requested review from heiruwu heiruwu is a code owner

@pinglin pinglin Awaiting requested review from pinglin pinglin is a code owner

@xiaofei-du xiaofei-du Awaiting requested review from xiaofei-du xiaofei-du is a code owner

Assignees
No one assigned
Labels
instill model
Projects
🔮 Instill Core
Status: 👋 Done
Milestone
No milestone
2 participants
@donch1989 @droplet-bot