Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(controller): add pipeline state monitoring with controller #134

Merged
merged 11 commits into from
Apr 7, 2023

Conversation

heiruwu
Copy link
Member

@heiruwu heiruwu commented Apr 5, 2023

Because

  • support pipeline state monitoring with controller

This commit

  • add public /watch endpoint for querying pipeline state from etcd through controller
  • use /watch in integration-test to reflect model current state

@linear
Copy link

linear bot commented Apr 5, 2023

@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Patch coverage: 33.33% and project coverage change: +1.57 🎉

Comparison is base (b1272eb) 11.68% compared to head (3dcf863) 13.25%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #134      +/-   ##
==========================================
+ Coverage   11.68%   13.25%   +1.57%     
==========================================
  Files           4        5       +1     
  Lines         993     1071      +78     
==========================================
+ Hits          116      142      +26     
- Misses        857      906      +49     
- Partials       20       23       +3     
Flag Coverage Δ
unittests 13.25% <33.33%> (+1.57%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/service/service.go 4.33% <16.21%> (+0.27%) ⬆️
pkg/service/controller.go 35.41% <35.41%> (ø)
pkg/service/state.go 54.38% <40.00%> (ø)
pkg/service/convert.go 18.49% <100.00%> (+2.92%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@heiruwu heiruwu marked this pull request as ready for review April 7, 2023 07:05
Copy link
Member

@pinglin pinglin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pinglin pinglin merged commit e77a8d8 into main Apr 7, 2023
10 of 11 checks passed
@pinglin pinglin deleted the heiru/ins-169-implement-controller-query-in-pipeline branch April 7, 2023 13:08
pinglin pushed a commit that referenced this pull request Apr 7, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.11.0-alpha](v0.10.0-alpha...v0.11.0-alpha)
(2023-04-07)


### Features

* **controller:** add pipeline state monitoring with controller
([#134](#134))
([e77a8d8](e77a8d8))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
pinglin pushed a commit that referenced this pull request Apr 9, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.11.0-alpha](v0.10.0-alpha...v0.11.0-alpha)
(2023-04-09)


### Features

* **controller:** add pipeline state monitoring with controller
([#134](#134))
([e77a8d8](e77a8d8))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
3 participants