Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix openapi using snake case #46

Merged
merged 1 commit into from
Mar 22, 2022
Merged

fix: fix openapi using snake case #46

merged 1 commit into from
Mar 22, 2022

Conversation

pinglin
Copy link
Member

@pinglin pinglin commented Mar 22, 2022

Because

  • response output standard follows snake_case to disambiguate REST and gRPC naming convention

This commit

  • configure openapiv2 plugin with json_names_for_fields=false based on the official guideline

Phelan164
Phelan164 approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@Phelan164 Phelan164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pinglin pinglin merged commit fe755b7 into main Mar 22, 2022
@pinglin pinglin deleted the fix-snake-case branch March 22, 2022 16:39
@droplet-bot droplet-bot mentioned this pull request Mar 22, 2022
Merged
@pinglin
Copy link
Member Author

pinglin commented Mar 22, 2022

Close issue #45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Phelan164 Phelan164 Phelan164 approved these changes

@xiaofei-du xiaofei-du Awaiting requested review from xiaofei-du xiaofei-du is a code owner

Assignees
No one assigned
Labels
None yet
Projects
🔮 Instill Core
Archived in project
Milestone
No milestone
2 participants
@pinglin @Phelan164