Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(model): add method create model by GitHub #49

Merged
merged 7 commits into from
Mar 30, 2022
Merged

feat(model): add method create model by GitHub #49

merged 7 commits into from
Mar 30, 2022

Conversation

Phelan164
Copy link
Contributor

Because

  • It is convenient for users when creating a model from their GitHub repository

This commit

  • Add a method to create a model by GitHub URL

@Phelan164 Phelan164 changed the title feat: add method create model by GitHub feat(model): add method create model by GitHub Mar 25, 2022
pinglin
pinglin requested changes Mar 27, 2022
View reviewed changes
Copy link
Member

@pinglin pinglin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others look good to me.

instill/model/v1alpha/model.proto Outdated Show resolved Hide resolved
@Phelan164 Phelan164 force-pushed the add-create-model-from-github branch from 81ab6c9 to 353aed5 Compare March 28, 2022 03:46
@Phelan164 Phelan164 requested a review from pinglin March 28, 2022 03:46
pinglin
pinglin previously approved these changes Mar 29, 2022
View reviewed changes
Copy link
Member

@pinglin pinglin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pinglin
pinglin requested changes Mar 29, 2022
View reviewed changes
instill/model/v1alpha/model.proto Outdated Show resolved Hide resolved
pinglin
pinglin previously approved these changes Mar 29, 2022
View reviewed changes
@pinglin pinglin force-pushed the add-create-model-from-github branch from 6399fb8 to 63510ec Compare March 29, 2022 20:27
@Phelan164 Phelan164 requested review from pinglin and EiffelFly and removed request for EiffelFly March 30, 2022 04:11
@pinglin pinglin merged commit 7ddc142 into main Mar 30, 2022
@pinglin pinglin deleted the add-create-model-from-github branch March 30, 2022 11:02
@droplet-bot droplet-bot mentioned this pull request Mar 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinglin pinglin pinglin approved these changes

@xiaofei-du xiaofei-du Awaiting requested review from xiaofei-du xiaofei-du is a code owner

Assignees
No one assigned
Labels
None yet
Projects
🔮 Instill Core
Archived in project
Milestone
No milestone
2 participants
@Phelan164 @pinglin