Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(model): move github from model to model version #51

Merged
merged 1 commit into from
Mar 30, 2022
Merged

fix(model): move github from model to model version #51

merged 1 commit into from
Mar 30, 2022

Conversation

Phelan164
Copy link
Contributor

@Phelan164 Phelan164 commented Mar 30, 2022 •
edited by pinglin
Loading

Because

  • model version has GitHub information including repository, branch, tag and commit hash

This commit

  • move GitHub from Model message to ModelVersion message

pinglin
pinglin approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@pinglin pinglin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pinglin pinglin merged commit 03170d7 into main Mar 30, 2022
@pinglin pinglin deleted the fix-model-github-info branch March 30, 2022 15:21
@droplet-bot droplet-bot mentioned this pull request Mar 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinglin pinglin pinglin approved these changes

@xiaofei-du xiaofei-du Awaiting requested review from xiaofei-du xiaofei-du is a code owner

Assignees
No one assigned
Labels
None yet
Projects
🔮 Instill Core
Archived in project
Milestone
No milestone
2 participants
@Phelan164 @pinglin