feat(connector): add protobuf #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phelan164
reviewed
Mar 31, 2022
| // Source connector ID | ||
| uint64 id = 1 [ (google.api.field_behavior) = OUTPUT_ONLY ]; | ||
| // Source connector name | ||
| string name = 2 [ (google.api.field_behavior) = REQUIRED ]; |
There was a problem hiding this comment.
@pinglin I think this message is only provided in response, then all fieds will be OUTPUT_ONLY. What do you think?
There was a problem hiding this comment.
That's correct. Message Source and Destination is used in only reponse. Will make a change.
pinglin
force-pushed
the
add-connector-protobuf
branch
from
cf01c00
to
45be63c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This commit