Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(model): add optional view param for GET operation #70

Merged
merged 2 commits into from
May 13, 2022
Merged

fix(model): add optional view param for GET operation #70

merged 2 commits into from
May 13, 2022

Conversation

xiaofei-du
Copy link
Member

@xiaofei-du xiaofei-du commented May 13, 2022 •
edited
Loading

Because

  • in GET operation, it is desirable to return results that the user is interested in

This commit

  • make view parameter optional
  • add view parameter to GET /model-definitions/*
  • add view parameter to GET /models/*
  • add view parameter to GET /models/*/instances/*
  • add view parameter to lookUp custom methods

pinglin
pinglin approved these changes May 13, 2022
View reviewed changes
Copy link
Member

@pinglin pinglin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pinglin pinglin merged commit a739d95 into main May 13, 2022
@pinglin pinglin deleted the fix-model-view branch May 13, 2022 16:09
@droplet-bot droplet-bot mentioned this pull request May 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinglin pinglin pinglin approved these changes

@Phelan164 Phelan164 Awaiting requested review from Phelan164

Assignees
No one assigned
Labels
None yet
Projects
🔮 Instill Core
Archived in project
Milestone
No milestone
2 participants
@xiaofei-du @pinglin