Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(model): change configuration from struct to string #72

Merged
merged 2 commits into from
May 16, 2022

Conversation

xiaofei-du
Copy link
Member

@xiaofei-du xiaofei-du commented May 15, 2022

Because

  • We can safely use string to replace google.protobuf.Struct for now, as google.protobuf.FieldMask just doesn’t work with google.protobuf.Struct at all. Another thing is that we store a JSON struct type in the database as JSONB and its GORM mapping is datatypes.JSON which is nothing but []byte (i.e., a string).

This commit

  • update configuration in model and model_instance from google.protobuf.Struct to string

Note:

This PR relies on #71.

@xiaofei-du xiaofei-du changed the base branch from fix-path-param to main May 15, 2022 22:41
@xiaofei-du xiaofei-du marked this pull request as draft May 15, 2022 22:42
@xiaofei-du xiaofei-du marked this pull request as ready for review May 15, 2022 23:35
Copy link
Member

@pinglin pinglin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
2 participants