Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INS-159] simplify the two-tier model and model instance structure #669

Closed
xiaofei-du opened this issue Mar 11, 2023 · 0 comments
Closed
Assignees

Comments

@xiaofei-du
Copy link
Member

xiaofei-du commented Mar 11, 2023

Is your feature request related to a problem?

The current design of model and model instance is clumsy. Check the doc here.

  • A model can have multiple model instances.
  • A model does not have state.
  • A model instance, as a second-tier resource, must belong to a model.
  • A model instance has state.

But

  • A model can't be a component of a pipeline.
  • A model instance is the core component of a pipeline.

For users who are not familiar with ML/AI or are new to VDP, it is difficult to understand the relationships between these resources and the concept of a model instance is the instantiation of a model.

Describe the solution you'd like

We simplify model and model instance into a flat model structure.

Let me use importing yolov7 from instill-ai/model-yolov7-dvc repo as an example. When the model is imported (e.g., GitHub):

With the current model and model instance design, there will be one model that has two model instances

  • model: yolov7
    • instance: v1.0-cpu
    • instance: v1.0-gpu

With the new model structure, there will be two models

  • model: yolov7-v1-0-cpu
  • model: yolov7-v1-0-gpu

With the new flat design,

  • There is no model instance concept any more.
  • A model is the core component of a pipeline.

From SyncLinear.com | INS-159

@xiaofei-du xiaofei-du changed the title Simplify the two tier model and model instance structure [INS-159] Simplify the two tier model and model instance structure Mar 11, 2023
@xiaofei-du xiaofei-du changed the title [INS-159] Simplify the two tier model and model instance structure [INS-159] simplify the two tier model and model instance structure Mar 11, 2023
@xiaofei-du xiaofei-du changed the title [INS-159] simplify the two tier model and model instance structure [INS-159] simplify the two-tier model and model instance structure Mar 11, 2023
@xiaofei-du xiaofei-du self-assigned this Mar 11, 2023
@xiaofei-du xiaofei-du changed the title [INS-159] simplify the two-tier model and model instance structure [INS-159] simplify the two-tier model and model instance structure Mar 28, 2023
@pinglin pinglin transferred this issue from instill-ai/instill-core Aug 24, 2023
@pinglin pinglin transferred this issue from instill-ai/community May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

1 participant