Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the default output #58

Merged
merged 1 commit into from Jul 28, 2019
Merged

Improve the default output #58

merged 1 commit into from Jul 28, 2019

Conversation

garethr
Copy link
Contributor

@garethr garethr commented Jul 28, 2019

The previous output suffers from a few issues:

  1. You need to read multiple lines to determine the issue and it's
    location
  2. Without the colors you can't tell errors from warnings
  3. It's not easily parsable

This adjusts things according to the discussion in #42

@garethr garethr added the enhancement New feature or request label Jul 28, 2019
Copy link
Collaborator

@brendanjryan brendanjryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

pkg/commands/test/output.go Outdated Show resolved Hide resolved
The previous output suffers from a few issues:

1. You need to read multiple lines to determine the issue and it's
location
2. Without the colors you can't tell errors from warnings
3. It's not easily parsable

This adjusts things according to the discussion in #42
@garethr garethr merged commit 604d8e6 into master Jul 28, 2019
@garethr garethr deleted the improve-cli-output branch August 9, 2019 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants