Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments on a PR with a large amount of matches aren't hidden #920

Open
asbjornu opened this issue Apr 4, 2024 · 1 comment
Open

Comments on a PR with a large amount of matches aren't hidden #920

asbjornu opened this issue Apr 4, 2024 · 1 comment

Comments

@asbjornu
Copy link

asbjornu commented Apr 4, 2024

I'm not sure what the cause of this is, but suddenly, comments have stopped being hidden in a particular PR with a very large amount of matches (using contains: …). If more was logged during execution, such as the number of matched comments by the applied filter, it could perhaps help to debug the problem.

@asbjornu
Copy link
Author

asbjornu commented Apr 17, 2024

It seems like the following line restricts the number of queried comments to 100, which would explain the behavior I'm seeing:

comments(last: 100, orderBy: { field: UPDATED_AT, direction: DESC }) {

Since it's also ordering the comments descending by UPDATED_AT, I suspect the same 100 comments to be returned on every query for a PR with more than 100 comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant