Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use entrypoints for known implementations #206

Closed
TomAugspurger opened this issue Nov 19, 2019 · 6 comments · Fixed by #515
Closed

Use entrypoints for known implementations #206

TomAugspurger opened this issue Nov 19, 2019 · 6 comments · Fixed by #515

Comments

@TomAugspurger
Copy link
Collaborator

TomAugspurger commented Nov 19, 2019

Right now, adding a new implementation to the dict of known_implementations requires some coordination between fsspec and the downstream library. This might include the downstream library mutating known_implementations as a side-effect of importing the library.

An alternative is to have fsspec add an entrypoint for implementations, and downstream libraries would add themselves to it.

@martindurant
Copy link
Member

This would require other packages outside of fsspec to participate by publishing their protocol entrypoints, but would remove the requirement for them to be either listed in known_implementations in this package or to modify the registry at import time.

@hayesgb
Copy link
Contributor

hayesgb commented Nov 25, 2019

@martindurant -- Do you want to list either of the abfs:// or adl:// protocols in the fsspec known_implementations, of should I go the route of entrypoints?

@TomAugspurger
Copy link
Collaborator Author

TomAugspurger commented Nov 25, 2019 via email

@martindurant
Copy link
Member

Did you already implement the entrypoints way in fsspec? In that case that should be the way. If not, a PR to fsspec adding the entries to known_implementations.

@TomAugspurger
Copy link
Collaborator Author

TomAugspurger commented Nov 25, 2019 via email

@martindurant
Copy link
Member

OK, so that's for the future. We want people to be accessing Azure right now, so lets add it into fsspec known_implementations forthwith.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants