-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use entrypoints for known implementations #206
Comments
This would require other packages outside of fsspec to participate by publishing their protocol entrypoints, but would remove the requirement for them to be either listed in known_implementations in this package or to modify the registry at import time. |
@martindurant -- Do you want to list either of the abfs:// or adl:// protocols in the fsspec known_implementations, of should I go the route of entrypoints? |
I think those choices are independent. You can register multiple
entrypoints within the ffspec group.
…On Mon, Nov 25, 2019 at 7:01 AM Greg Hayes ***@***.***> wrote:
@martindurant <https://github.com/martindurant> -- Do you want to list
either of the abfs:// or adl:// protocols in the fsspec
known_implementations, of should I go the route of entrypoints/
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#206>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKAOIQNTVD6FW3A55ATVVLQVPECZANCNFSM4JPF6ZWQ>
.
|
Did you already implement the entrypoints way in fsspec? In that case that should be the way. If not, a PR to fsspec adding the entries to known_implementations. |
No, I haven't implemented it yet. I can later today if there's interest.
…On Mon, Nov 25, 2019 at 8:08 AM Martin Durant ***@***.***> wrote:
Did you already implement the entrypoints way in fsspec? In that case that
should be the way. If not, a PR to fsspec adding the entries to
known_implementations.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#206>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKAOISVKR7YXQELTZ7EOD3QVPL6ZANCNFSM4JPF6ZWQ>
.
|
OK, so that's for the future. We want people to be accessing Azure right now, so lets add it into fsspec known_implementations forthwith. |
Right now, adding a new implementation to the dict of
known_implementations
requires some coordination between fsspec and the downstream library. This might include the downstream library mutatingknown_implementations
as a side-effect of importing the library.An alternative is to have fsspec add an entrypoint for implementations, and downstream libraries would add themselves to it.
The text was updated successfully, but these errors were encountered: